Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #20999 - Reset env/cv for Activation Keys #7351

Merged
merged 1 commit into from May 10, 2018

Conversation

parthaa
Copy link
Contributor

@parthaa parthaa commented May 2, 2018

This commit allows one unset the environment and content view for
activation keys via the UI.

@theforeman-bot
Copy link

Issues: #20999

@parthaa
Copy link
Contributor Author

parthaa commented May 2, 2018

Behavior

  • Added the reset button 'X' next to the content view selection box to reset the CV for the activation key
  • If you unselect an environment, it will reset the content view also.

testak

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the video

activationKey["content_view_id"] = null;
activationKey["content_view"] = null;
$scope.saveContentView(activationKey);
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoudln't this unset the lifecycle environment too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlsherrill good point. Will look into it. One of the issues is that with the current environment selector resetting is harder than setting activationKey.environment = null.
@jlsherrill @Rohoover should I just get rid of it ?

@parthaa
Copy link
Contributor Author

parthaa commented May 9, 2018

@jlsherrill @jturel @Rohoover after giving a valiant fight to vanquish the evil env selector I decided its easier to just reset the existing selector. So here is the new behavior. (Too many challenges with the tree design especially on the AK edit page.)

ak-new

@parthaa
Copy link
Contributor Author

parthaa commented May 9, 2018

In short reseting Content View will wipe out environment and Unchecking env will reset the content view

@jturel
Copy link
Member

jturel commented May 9, 2018

@parthaa
Copy link
Contributor Author

parthaa commented May 9, 2018

When content view has been cleared clicking into the dropdown will throw an error (Cannot read property id of null)
Ok updated the behavior a little. Basically you cant select the content view unless you have an environment selected. Check the new version

aka-3

Copy link
Member

@jturel jturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely - APJ

Thanks!

@parthaa
Copy link
Contributor Author

parthaa commented May 9, 2018

[test]

This commit allows one unset the environment and content view for
activation keys via the UI.
@parthaa
Copy link
Contributor Author

parthaa commented May 10, 2018

[test katello]

@parthaa parthaa merged commit 8c5b23f into Katello:master May 10, 2018
@parthaa parthaa deleted the ak-env-cv branch May 10, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants