New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #20999 - Reset env/cv for Activation Keys #7351
Conversation
Issues: #20999 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the video
activationKey["content_view_id"] = null; | ||
activationKey["content_view"] = null; | ||
$scope.saveContentView(activationKey); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shoudln't this unset the lifecycle environment too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlsherrill good point. Will look into it. One of the issues is that with the current environment selector resetting is harder than setting activationKey.environment = null
.
@jlsherrill @Rohoover should I just get rid of it ?
@jlsherrill @jturel @Rohoover after giving a valiant fight to vanquish the evil env selector I decided its easier to just reset the existing selector. So here is the new behavior. (Too many challenges with the tree design especially on the AK edit page.) |
In short reseting Content View will wipe out environment and Unchecking env will reset the content view |
When content view has been cleared clicking into the dropdown will throw an error (Cannot read property id of null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely - APJ
Thanks!
[test] |
This commit allows one unset the environment and content view for activation keys via the UI.
[test katello] |
This commit allows one unset the environment and content view for
activation keys via the UI.