Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23680 - Content type selector on Red Hat Repos page is empty #7405

Merged
merged 1 commit into from May 30, 2018

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented May 30, 2018

Anything beyond version 1.12.4 causes css breakage because patternfly-sass is not up to date with the most current version of bootstrap-select. The newest version of bootstrap-select adds some css class that aren't currently in patternfly-sass

@theforeman-bot
Copy link

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • 9d1f6e9 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@chalettu chalettu changed the title Fixes 23680 Content type selector on Red Hat Repos page is empty Fixes #23680 - Content type selector on Red Hat Repos page is empty May 30, 2018
@theforeman-bot
Copy link

There were the following issues with the commit message:

  • length of the first commit message line for a08558b exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@chalettu
Copy link
Contributor Author

Screenshot of fix in action.
katello_bug

Copy link
Contributor

@waldenraines waldenraines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this fix as we aim to replace bootstrap-select with a react-patternfly version in the future.

Tested and works.

@waldenraines waldenraines merged commit 8fb712a into Katello:master May 30, 2018
@waldenraines
Copy link
Contributor

Thanks @chalettu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants