Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25978 - Debian Errata support #7961

Open
wants to merge 28 commits into
base: master
from

Conversation

@m-bucher
Copy link
Contributor

commented Feb 4, 2019

Depends on #7418
Add support for Debian/Ubuntu errata using external service, which:

  1. parses Debian Security Announcements (DSA) and Ubuntu Security Notices (USN): https://github.com/ATIX-AG/errata_parser

  2. serves the resulting errata: https://github.com/ATIX-AG/errata_server

@theforeman-bot

This comment has been minimized.

Copy link

commented Feb 4, 2019

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

@theforeman-bot

This comment has been minimized.

Copy link

commented Feb 4, 2019

There were the following issues with the commit message:

  • a7e84d6 must be in the format fixes #redmine_number - brief description
  • 0cefc50 must be in the format fixes #redmine_number - brief description
  • 5c63609 must be in the format fixes #redmine_number - brief description
  • 6d04780 must be in the format fixes #redmine_number - brief description
  • 66b4138 must be in the format fixes #redmine_number - brief description
  • 9e2d4a1 must be in the format fixes #redmine_number - brief description
  • c9b8b94 must be in the format fixes #redmine_number - brief description
  • 524589c must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for 524589c exceeds 65 characters
  • 79da3ce must be in the format fixes #redmine_number - brief description
  • d2ec936 must be in the format fixes #redmine_number - brief description
  • 210d749 must be in the format fixes #redmine_number - brief description
  • 403dddd must be in the format fixes #redmine_number - brief description
  • 9333543 must be in the format fixes #redmine_number - brief description
  • ce61601 must be in the format fixes #redmine_number - brief description
  • 56f5391 must be in the format fixes #redmine_number - brief description
  • b22016a must be in the format fixes #redmine_number - brief description
  • d0c1e32 must be in the format fixes #redmine_number - brief description
  • 53caf97 must be in the format fixes #redmine_number - brief description
  • 44635fd must be in the format fixes #redmine_number - brief description
  • dee8f32 must be in the format fixes #redmine_number - brief description
  • 0cc7ce9 must be in the format fixes #redmine_number - brief description
  • 1220020 must be in the format fixes #redmine_number - brief description
  • 3020f82 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot

This comment has been minimized.

Copy link

commented Feb 5, 2019

There were the following issues with the commit message:

  • a7e84d6 must be in the format fixes #redmine_number - brief description
  • 0cefc50 must be in the format fixes #redmine_number - brief description
  • 5c63609 must be in the format fixes #redmine_number - brief description
  • 6d04780 must be in the format fixes #redmine_number - brief description
  • 66b4138 must be in the format fixes #redmine_number - brief description
  • 9e2d4a1 must be in the format fixes #redmine_number - brief description
  • c9b8b94 must be in the format fixes #redmine_number - brief description
  • 524589c must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for 524589c exceeds 65 characters
  • 79da3ce must be in the format fixes #redmine_number - brief description
  • d2ec936 must be in the format fixes #redmine_number - brief description
  • 210d749 must be in the format fixes #redmine_number - brief description
  • 403dddd must be in the format fixes #redmine_number - brief description
  • 9333543 must be in the format fixes #redmine_number - brief description
  • ce61601 must be in the format fixes #redmine_number - brief description
  • 56f5391 must be in the format fixes #redmine_number - brief description
  • b22016a must be in the format fixes #redmine_number - brief description
  • d0c1e32 must be in the format fixes #redmine_number - brief description
  • 53caf97 must be in the format fixes #redmine_number - brief description
  • 44635fd must be in the format fixes #redmine_number - brief description
  • dee8f32 must be in the format fixes #redmine_number - brief description
  • 0cc7ce9 must be in the format fixes #redmine_number - brief description
  • 1220020 must be in the format fixes #redmine_number - brief description
  • 3020f82 must be in the format fixes #redmine_number - brief description
  • 470ffa3 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@tbrisker

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

[test katello]

@theforeman-bot

This comment has been minimized.

Copy link

commented Feb 6, 2019

There were the following issues with the commit message:

  • a7e84d6 must be in the format fixes #redmine_number - brief description
  • 0cefc50 must be in the format fixes #redmine_number - brief description
  • 5c63609 must be in the format fixes #redmine_number - brief description
  • 6d04780 must be in the format fixes #redmine_number - brief description
  • 66b4138 must be in the format fixes #redmine_number - brief description
  • 9e2d4a1 must be in the format fixes #redmine_number - brief description
  • c9b8b94 must be in the format fixes #redmine_number - brief description
  • 524589c must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for 524589c exceeds 65 characters
  • 79da3ce must be in the format fixes #redmine_number - brief description
  • d2ec936 must be in the format fixes #redmine_number - brief description
  • 210d749 must be in the format fixes #redmine_number - brief description
  • 403dddd must be in the format fixes #redmine_number - brief description
  • 9333543 must be in the format fixes #redmine_number - brief description
  • ce61601 must be in the format fixes #redmine_number - brief description
  • 56f5391 must be in the format fixes #redmine_number - brief description
  • b22016a must be in the format fixes #redmine_number - brief description
  • d0c1e32 must be in the format fixes #redmine_number - brief description
  • 53caf97 must be in the format fixes #redmine_number - brief description
  • 44635fd must be in the format fixes #redmine_number - brief description
  • dee8f32 must be in the format fixes #redmine_number - brief description
  • 0cc7ce9 must be in the format fixes #redmine_number - brief description
  • 1220020 must be in the format fixes #redmine_number - brief description
  • 3020f82 must be in the format fixes #redmine_number - brief description
  • 470ffa3 must be in the format fixes #redmine_number - brief description
  • e63f390 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@m-bucher

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2019

Forgot to mention that this depends on #7418, which is also the reason for some test-failures:

NameError: uninitialized constant Katello::InstalledDeb

Not sure though, if it makes sense to rebase this PR on the other branch(, if #7418 is on the brink of being merged 😉 )

@theforeman-bot

This comment has been minimized.

Copy link

commented Feb 19, 2019

There were the following issues with the commit message:

  • a7e84d6 must be in the format fixes #redmine_number - brief description
  • 0cefc50 must be in the format fixes #redmine_number - brief description
  • 5c63609 must be in the format fixes #redmine_number - brief description
  • 6d04780 must be in the format fixes #redmine_number - brief description
  • 66b4138 must be in the format fixes #redmine_number - brief description
  • 9e2d4a1 must be in the format fixes #redmine_number - brief description
  • c9b8b94 must be in the format fixes #redmine_number - brief description
  • 524589c must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for 524589c exceeds 65 characters
  • 79da3ce must be in the format fixes #redmine_number - brief description
  • d2ec936 must be in the format fixes #redmine_number - brief description
  • 210d749 must be in the format fixes #redmine_number - brief description
  • 403dddd must be in the format fixes #redmine_number - brief description
  • 9333543 must be in the format fixes #redmine_number - brief description
  • ce61601 must be in the format fixes #redmine_number - brief description
  • 56f5391 must be in the format fixes #redmine_number - brief description
  • b22016a must be in the format fixes #redmine_number - brief description
  • d0c1e32 must be in the format fixes #redmine_number - brief description
  • 53caf97 must be in the format fixes #redmine_number - brief description
  • 44635fd must be in the format fixes #redmine_number - brief description
  • dee8f32 must be in the format fixes #redmine_number - brief description
  • 0cc7ce9 must be in the format fixes #redmine_number - brief description
  • 1220020 must be in the format fixes #redmine_number - brief description
  • 3020f82 must be in the format fixes #redmine_number - brief description
  • 470ffa3 must be in the format fixes #redmine_number - brief description
  • e63f390 must be in the format fixes #redmine_number - brief description
  • c71e832 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

Can one of the admins verify this patch?

@theforeman-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

There were the following issues with the commit message:

  • a7e84d6 must be in the format fixes #redmine_number - brief description
  • 0cefc50 must be in the format fixes #redmine_number - brief description
  • 5c63609 must be in the format fixes #redmine_number - brief description
  • 6d04780 must be in the format fixes #redmine_number - brief description
  • 66b4138 must be in the format fixes #redmine_number - brief description
  • 9e2d4a1 must be in the format fixes #redmine_number - brief description
  • c9b8b94 must be in the format fixes #redmine_number - brief description
  • 524589c must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for 524589c exceeds 65 characters
  • 79da3ce must be in the format fixes #redmine_number - brief description
  • d2ec936 must be in the format fixes #redmine_number - brief description
  • 210d749 must be in the format fixes #redmine_number - brief description
  • 403dddd must be in the format fixes #redmine_number - brief description
  • 9333543 must be in the format fixes #redmine_number - brief description
  • ce61601 must be in the format fixes #redmine_number - brief description
  • 56f5391 must be in the format fixes #redmine_number - brief description
  • b22016a must be in the format fixes #redmine_number - brief description
  • d0c1e32 must be in the format fixes #redmine_number - brief description
  • 53caf97 must be in the format fixes #redmine_number - brief description
  • 44635fd must be in the format fixes #redmine_number - brief description
  • dee8f32 must be in the format fixes #redmine_number - brief description
  • 0cc7ce9 must be in the format fixes #redmine_number - brief description
  • 1220020 must be in the format fixes #redmine_number - brief description
  • 3020f82 must be in the format fixes #redmine_number - brief description
  • 470ffa3 must be in the format fixes #redmine_number - brief description
  • e63f390 must be in the format fixes #redmine_number - brief description
  • c71e832 must be in the format fixes #redmine_number - brief description
  • 594b90a must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@tbrisker

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

ok to test

@tbrisker

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@m-bucher looks like this has some merge conflicts now. I've also invited you to the katello org so the bot will auto test your prs

@jturel

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

@m-bucher now that #7418 is merged I'm prepared to test this in earnest once rebased. Looking forward to getting this merged in.

@jturel

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

@m-bucher could you also provide steps on how to test this end-to-end ?

@bkearney

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

@m-bucher how goes this PR? Anything we can do to move it along?

@m-bucher

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

@jturel thanks for the offer.
We currently work on rebasing it to the latest upstream-katello.

For testing you need to configure a deb Repository for the Debian (or Ubuntu) security-updates repository, where you configure the URL of a running instance of our errata-parser-service in the Errata URL-field.

You may use our running instance at https://dep.atix.de/dep/api/v1/debian for Debian or https://dep.atix.de/dep/api/v1/ubuntu for Ubuntu, when testing.

For example:

Upstream URL: http://security.debian.org/debian-security/
Releases: stretch/updates
Errata URL: https://dep.atix.de/dep/api/v1/debian
@bkearney

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Thanks @m-bucher, while the PR gets rebased is there anything we can do?

@m-bucher m-bucher force-pushed the ATIX-AG:feature/debian_errata branch from 594b90a to 418dd18 Jul 4, 2019

@theforeman-bot

This comment has been minimized.

Copy link

commented Jul 4, 2019

There were the following issues with the commit message:

  • a4190f5 must be in the format fixes #redmine_number - brief description
  • bb74b89 must be in the format fixes #redmine_number - brief description
  • f5108d0 must be in the format fixes #redmine_number - brief description
  • dd0ce30 must be in the format fixes #redmine_number - brief description
  • 091f489 must be in the format fixes #redmine_number - brief description
  • 34a97c0 must be in the format fixes #redmine_number - brief description
  • 1b6ff6d must be in the format fixes #redmine_number - brief description
  • d3522e4 must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for d3522e4 exceeds 65 characters
  • 7ba7aaa must be in the format fixes #redmine_number - brief description
  • 862f506 must be in the format fixes #redmine_number - brief description
  • 3a4e894 must be in the format fixes #redmine_number - brief description
  • aa04975 must be in the format fixes #redmine_number - brief description
  • 1dd1042 must be in the format fixes #redmine_number - brief description
  • 743c46b must be in the format fixes #redmine_number - brief description
  • 42101ae must be in the format fixes #redmine_number - brief description
  • db519b9 must be in the format fixes #redmine_number - brief description
  • e02d52a must be in the format fixes #redmine_number - brief description
  • cda1de9 must be in the format fixes #redmine_number - brief description
  • 3464afe must be in the format fixes #redmine_number - brief description
  • a58b0c4 must be in the format fixes #redmine_number - brief description
  • 5decd91 must be in the format fixes #redmine_number - brief description
  • 9df709f must be in the format fixes #redmine_number - brief description
  • 418dd18 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

mdellweg and others added some commits Apr 9, 2018

Save affected deb_packages
If the affected package preexisted, its version was not updated.

@m-bucher m-bucher force-pushed the ATIX-AG:feature/debian_errata branch from a0c3c0d to 267f3d9 Aug 16, 2019

@theforeman-bot

This comment has been minimized.

Copy link

commented Aug 16, 2019

There were the following issues with the commit message:

  • 6cd1b68 must be in the format fixes #redmine_number - brief description
  • 1543d0d must be in the format fixes #redmine_number - brief description
  • b96efb8 must be in the format fixes #redmine_number - brief description
  • a2dfa97 must be in the format fixes #redmine_number - brief description
  • 6dbac8a must be in the format fixes #redmine_number - brief description
  • de9bfba must be in the format fixes #redmine_number - brief description
  • 472c57e must be in the format fixes #redmine_number - brief description
  • d07e8f6 must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for d07e8f6 exceeds 65 characters
  • 48b8fd6 must be in the format fixes #redmine_number - brief description
  • 77c3a15 must be in the format fixes #redmine_number - brief description
  • 124c980 must be in the format fixes #redmine_number - brief description
  • b05b921 must be in the format fixes #redmine_number - brief description
  • b29de03 must be in the format fixes #redmine_number - brief description
  • 3bbe4fd must be in the format fixes #redmine_number - brief description
  • fcd9703 must be in the format fixes #redmine_number - brief description
  • 2fe2734 must be in the format fixes #redmine_number - brief description
  • 06b3d97 must be in the format fixes #redmine_number - brief description
  • 21f618c must be in the format fixes #redmine_number - brief description
  • 8f63a6e must be in the format fixes #redmine_number - brief description
  • 7c3584f must be in the format fixes #redmine_number - brief description
  • 5969a90 must be in the format fixes #redmine_number - brief description
  • debb1ba must be in the format fixes #redmine_number - brief description
  • 118a5f7 must be in the format fixes #redmine_number - brief description
  • df105f0 must be in the format fixes #redmine_number - brief description
  • e320a52 must be in the format fixes #redmine_number - brief description
  • 7fdb99b must be in the format fixes #redmine_number - brief description
  • f16fb06 must be in the format fixes #redmine_number - brief description
  • 267f3d9 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.