fixes #27050 - Activation Keys to support System Purpose #8168
Conversation
|
Can one of the admins verify this patch? |
|
Issues: #27050 |
|
[test katello] |
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
|
[test katello] |
|
@sseelam2 this looks really good - can you squash into a single commit? I'll merge after that |
sseelam2
force-pushed
the
activation_keys_sys_purpose
branch
from
fef9d08
to
4a625c2
Compare
|
Thank you for reviewing @jturel. I've squashed it into a single commit. |
| @@ -0,0 +1,11 @@ | |||
| class AddActivationKeyPurposeAddons < ActiveRecord::Migration[5.2] | |||
There was a problem hiding this comment.
Looks like you lost the code which renamed this migration
| @@ -45,3 +45,14 @@ library_dev_staging_view_key: | |||
| environment_id: <%= ActiveRecord::FixtureSet.identify(:dev) %> | |||
| content_view_id: <%= ActiveRecord::FixtureSet.identify(:library_dev_staging_view) %> | |||
| auto_attach: true | |||
|
|
|||
| key_purpose_attributes: | |||
There was a problem hiding this comment.
we don't need to name this 'key_' ... we already know it's an activation key :)
There was a problem hiding this comment.
Yes, you are correct. But I'm following a pattern which exists. I renamed it to purpose_attributes_key.
test/models/activation_key_test.rb
Outdated
| @@ -8,6 +8,7 @@ def setup | |||
| @dev_view = katello_content_views(:library_dev_view) | |||
| @lib_view = katello_content_views(:library_view) | |||
| @pool_one = katello_pools(:pool_one) | |||
| @purpose_attributes = katello_activation_keys(:key_purpose_attributes) | |||
There was a problem hiding this comment.
maybe 'purpose_key' would be a better name for this variable ?
There was a problem hiding this comment.
Yah. That sounds good. Renamed it. 👍
sseelam2
force-pushed
the
activation_keys_sys_purpose
branch
from
4a625c2
to
c31deec
Compare
sseelam2
force-pushed
the
activation_keys_sys_purpose
branch
from
570ef49
to
c31deec
Compare
|
[test katello] |
sseelam2
force-pushed
the
activation_keys_sys_purpose
branch
from
d2c334f
to
ce13e35
Compare
|
[test katello] |
|
Thanks @jturel for guiding me. 👍 |
This PR was created to use the functionality of Candlepin to support System Purpose on Activation Keys.
Since the UI isn't set up yet for the System Purpose under Activation Key, please use the api /katello/api/v2/activation_keys/1? to test the update and create functionality.
To test this PR:
Create and update purpose_role, purpose_usage and purpose_addons in an activation key using the api endpoint. This change should reflect in both Katello and Candlepin db.
View Katello::ActivationKey to see changes in the Katello db.
View Katello::Resources::Candlepin::ActivationKey.get to see changes made to Candlepin.