CLI refactoring #84

Merged
merged 8 commits into from May 9, 2012

Projects

None yet

4 participants

@tstrachota
Katello Project member

Contains following changes:

  • removed circular dependency from systems api
  • new util method get_system to lower code duplicity
  • api util methods now raise exceptions instead of returning None (easier usage, no need for ubiquitous if-is-None conditions)
  • new method for testing success of just created records
@iNecas iNecas was assigned May 7, 2012
@iNecas
Katello Project member

I got 45 errors and 2 failures when running nosetests

@tstrachota
Katello Project member

Ah, I was too fast with hitting 'pull request'. Thanks!

@ehelms
Katello Project member

Sounds like this pull request should be closed and re-opened after the changes?

@tstrachota
Katello Project member

Unit tests fixed. I also removed unused imports and did some basic pep8 cleaning.

@pitr-ch pitr-ch was assigned May 9, 2012
@pitr-ch
Katello Project member

This looks great and much cleaner :) I have only one suggestion to remove remaining long lines.

@tstrachota
Katello Project member

I've split the longest lines with messages into two. It's squashed in the pep8 fixes commit.

@pitr-ch pitr-ch merged commit 96d8d6e into Katello:master May 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment