Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

CLI refactoring #84

Merged
merged 8 commits into from

4 participants

@tstrachota

Contains following changes:

  • removed circular dependency from systems api
  • new util method get_system to lower code duplicity
  • api util methods now raise exceptions instead of returning None (easier usage, no need for ubiquitous if-is-None conditions)
  • new method for testing success of just created records
@iNecas iNecas was assigned
@iNecas
Owner

I got 45 errors and 2 failures when running nosetests

@tstrachota

Ah, I was too fast with hitting 'pull request'. Thanks!

@ehelms
Owner

Sounds like this pull request should be closed and re-opened after the changes?

@tstrachota

Unit tests fixed. I also removed unused imports and did some basic pep8 cleaning.

@pitr-ch pitr-ch was assigned
@pitr-ch

This looks great and much cleaner :) I have only one suggestion to remove remaining long lines.

@tstrachota

I've split the longest lines with messages into two. It's squashed in the pep8 fixes commit.

@pitr-ch pitr-ch merged commit 96d8d6e into Katello:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 9, 2012
  1. @tstrachota
  2. @tstrachota
  3. @tstrachota

    cli - api util methods changed to raise exceptions

    tstrachota authored
    instead of returning None when a record was not found.
    This allows us to remove the ubiquitous checks for None value from action bodies.
  4. @tstrachota
  5. @tstrachota

    task list cli - print part refactored

    tstrachota authored
    Duplicit lines removed and changed to use new style printer.
  6. @tstrachota
  7. @tstrachota

    cli - fixes in unit tests

    tstrachota authored
  8. @tstrachota

    cli - pep8 fixes

    tstrachota authored
    - code reidentation
    - trailing spaces removal
    - unused imports removed
Something went wrong with that request. Please try again.