Fixes #28714 - Limit the certificate end date to late 2049 #8507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscription-manager (python-rhsm) can't read the certificate with end date deyond 2049 year correctly. It will read the date as 1949 year which causing the pool of the custom products not accessible.
|
Can one of the admins verify this patch? |
|
Issues: #28714 |
|
ok to test |
jlsherrill
approved these changes
Jan 10, 2020
|
This fails |
ekohl
reviewed
Jan 10, 2020
| # End it 100 years from now | ||
| end_date ||= start_date + 10_950.days | ||
|
|
||
| # Subscription-manager (python-rhsm) can't read the certificate with end date deyond |
There was a problem hiding this comment.
Suggested change
| # Subscription-manager (python-rhsm) can't read the certificate with end date deyond | |
| # Subscription-manager (python-rhsm) can't read the certificate with end date beyond |
|
|
||
| # Subscription-manager (python-rhsm) can't read the certificate with end date deyond | ||
| # 2049 year correctly. Refer the links below for more details: | ||
| # https://bugzilla.redhat.com/show_bug.cgi?id=1789654 |
There was a problem hiding this comment.
Most of the comments are private, such as linking to RFC 5280 that states:
CAs conforming to this profile MUST always encode certificate validity dates through the year 2049 as UTCTime; certificate validity dates in 2050 or later MUST be encoded as GeneralizedTime.
There was a problem hiding this comment.
i can make that comment not-private
| # 2049 year correctly. Refer the links below for more details: | ||
| # https://bugzilla.redhat.com/show_bug.cgi?id=1789654 | ||
| # https://github.com/candlepin/candlepin/blob/5b87865f304555c112982af4fbc83a1c463d37b2 | ||
| # /server/src/main/java/org/candlepin/model/UeberCertificateGenerator.java#L247 |
There was a problem hiding this comment.
Not sure how useful it is to split a URL over multiple lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscription-manager (python-rhsm) can't read the certificate
with end date deyond 2049 year correctly. It will read the date
as 1949 year which causing the pool of the custom products not
accessible.