Fixes #31422 - Update Rubocop to new Lint/MissingSuper #9059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #31422 |
|
@jlsherrill here are the remaining lint failures with fixing things up in the test folder. |
|
looks like that change actually broke some tests :( I think _() conflicts with the i18n, and thus we'd have to use _{} Maybe just disable that cop for now? |
jlsherrill
reviewed
Dec 2, 2020
jlsherrill
reviewed
Dec 2, 2020
jlsherrill
reviewed
Dec 2, 2020
|
few comments, but everything else looks good 👍 |
|
@jlsherrill all green :) |
|
yay!!! Can you open an issue to re-enable those 4 cops? |
jlsherrill
approved these changes
Dec 2, 2020
Opened this guy: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.