Fixes #32580 - remove pulp2 actions except for capsule sync #9353
+85
−591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #32580 |
theforeman-bot
added
Waiting on contributor
Needs testing
Not yet reviewed
and removed
Waiting on contributor
labels
|
[test katello] |
jjeffers
force-pushed
the
32580_remove_pulp2_from_content_view_actions
branch
from
c4d316a
to
4d2e6c9
Compare
jjeffers
changed the title
jjeffers
changed the title
jjeffers
commented
Jun 11, 2021
| copy_output += copy_yum_content(new_repo, solve_dependencies, | ||
| content[:package_ids], | ||
| content[:errata_ids]) | ||
|
|
||
| plan_action(Katello::Repository::MetadataGenerate, new_repo) |
There was a problem hiding this comment.
@jlsherrill Since we are removing the unit copy here for pulp2 - are the following metadata generation and indexing required?
There was a problem hiding this comment.
It looks like today there are two branches in this code:
- pulp3 with yum
- everything else
and really the only thing supported with everything else is
- pulp2 w/yum
- pulp2 w/ deb
Which means that pulp3 w/deb is not supported via inc update, and no other content types are (which is expected).
However, reading the pulp3 with yum branch, i'm not sure where the publications are getting created, or the content is getting indexed? Maybe i'm missing something...
There was a problem hiding this comment.
I think what you've got is fine, let me file a card to investigate this
|
don't forget to squash! |
They call me Sir Squashalot. |
jjeffers
force-pushed
the
32580_remove_pulp2_from_content_view_actions
branch
from
489e716
to
4da16c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove pulp2 action from the content view actions for publish, promote, etc.
In some cases the sub-actions planned included additional pulp2 specific planing options, which are also removed.
Open questions: 1. what have I missed (are there actions I am not considering in this PR wrt to content views)? 2. should the PR expand to include other pulp2 actions, such as for non-capsule operations?