Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #33951 - Don't show RH Repos page in disconnected mode #9796

Closed

Conversation

jeremylenz
Copy link
Member

@jeremylenz jeremylenz commented Nov 18, 2021

What are the changes introduced in this pull request?

  • Don't show the Red Hat Repositories page in the nav when in disconnected mode
  • Update repository sets api to not provide available repository sets if disconnected

Considerations taken when implementing this change?

Since one does not have access to available repositories we can't really enable anything via this page.

I added a 403 response to /repository_sets with the explanatory error. I chose 403 Forbidden because the spec says this means "The server understood the request, but is refusing to fulfill it." I think that fits pretty well.

  • Are there other endpoints I should also block, besides index?
  • I decided not to change any wording etc. on the RH Repositories page, because it won't be displayed anyway

What are the testing steps for this pull request?

  1. Settings > Content > Disconnected mode > Yes
  2. Upon page refresh, verify that Red Hat Repositories is not listed in the navigation
  3. Verify API error when trying to list repository sets (you can still go to /redhat_repositories manually to try it)
  4. Turn the setting back to No and refresh the page; RH Repos should reappear in the nav

@theforeman-bot
Copy link

Issues: #33951

@jeremylenz jeremylenz marked this pull request as ready for review November 18, 2021 18:01
@jlsherrill
Copy link
Member

jlsherrill commented Nov 18, 2021

I assume we don't want to support the situation where:

  1. a satellite is disconnected
  2. they are syncing from locally available CDN source, such as previous iso content? (i agree this use case may be a stretch, but wanted to bring it up)

Also how does this affect ISS? Couldn't a satellite be disconnected (i.e. not able to talk to the portal), but still want to enable repos from another satellite? @jturel question for you here since you worked on ISS :)

@jeremylenz
Copy link
Member Author

@parthaa would also like your input on how this affects disconnected Satellites :)

@parthaa
Copy link
Contributor

parthaa commented Nov 19, 2021

parthaa would also like your input on how this affects disconnected Satellites :)

@jlsherrill brings up a good point.
That being said I 'd think Disconected should really only apply for Airgapped Disconnected setups. If its talking to a different CDN I 'd consider that a Connected case

@jlsherrill
Copy link
Member

I feel like there are two aspects:
Disconnected subscriptions
Disconnected content

and we're trying to combine them both with one setting, which maybe isn't appropriate ?

@jeremylenz
Copy link
Member Author

Closing in favor of a future PR from Partha after the design discussion today.

@jeremylenz jeremylenz closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants