Fixes #18076 - Can set OSTree repo depth #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables one to set the importer depth value for the ostree repo. look at http://projects.theforeman.org/issues/18076 for more info.
jlsherrill
reviewed
Feb 9, 2017
| @@ -4,7 +4,7 @@ class OstreeImporter < Importer | |||
| ID = 'ostree_web_importer'.freeze | |||
| REPO_TYPE = 'OSTREE'.freeze | |||
|
|
|||
| attr_accessor 'branches' | |||
| attr_accessor 'branches', 'depth' | |||
There was a problem hiding this comment.
should depth have a default value? or is nil okay and what does nil signify? everything?
There was a problem hiding this comment.
@jlsherrill good question. I guess on the katlelo side I am setting it to 0 by default so never noticed.
There was a problem hiding this comment.
@jlsherrill found the answer
> Runcible::Models::OstreeImporter.new(:depth => 10).config
=> {"depth"=>10}
> Runcible::Models::OstreeImporter.new(:feed => "http://ostree-house.org").config
=> {"feed"=>"http://ostree-house.org"}
> gg=Runcible::Models::OstreeImporter.new()
=> #<Runcible::Models::OstreeImporter:0x00000001403b88>
> gg.depth = 1
=> 1
gg.config
=> {"depth"=>1}
> gg.depth=nil
=> nil
> gg.config
=> {"depth"=>nil}
In short unless you forcibly set depth to nil, its going to work ok. Pulp will not get set the depth value if you don't provide the importer one. So imo no defaults are needed here.
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables one to set the importer depth value for the ostree repo.
look at http://projects.theforeman.org/issues/18076 for more info.