Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix all pkgs with 'khi_' #10

Merged
merged 6 commits into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@d-nakamichi
Copy link
Member

commented Apr 4, 2019

This PR converts all of packages to khi_* for #4
It changes only package(directory) names.

@d-nakamichi d-nakamichi requested a review from matsui-hiro Apr 4, 2019

@d-nakamichi d-nakamichi force-pushed the d-nakamichi:khi_prefix branch from d696ed7 to 8f1d5c4 Apr 5, 2019

@d-nakamichi

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

I rebased on master to solve a conflict.

@matsui-hiro I think master currently has a problem about #8 (comment)
Please consider to fix it.

@gavanderhoorn

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

@d-nakamichi wrote:

It changes only package(directory) names.

the PR seems to change more than just the directory names, correct?

I would also expect there to be more changes needed.

@d-nakamichi

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

@gavanderhoorn

the PR seems to change more than just the directory names, correct?

Is that means it changes codes of package references like this, right?
It changes package(directory) names and those referenced codes. may be correct.

I would also expect there to be more changes needed.

I've already check it OK to build and execute moveit demo, although I'm concerned about #8 (comment) (this is about urdf/srdf robot name)
What the expected changes, for example?

@gavanderhoorn

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

All references to the old package names would need to be replaced with the new names.

I've already check it OK to build and execute moveit demo, although I'm concerned about #8 (comment) (this is about urdf/srdf robot name)

For MoveIt configurations, it may be easier to just recreate them (as they're mostly auto-generated anyway by the Setup Assistant).

For the rest of the packages: if you've compile tested this (and Travis has done that as well) and tested the launch files things should be fine.

We might want to add more roslaunch tests to automatically test whether roslaunch can still find all the packages, just as I did in #5.

@d-nakamichi d-nakamichi force-pushed the d-nakamichi:khi_prefix branch from 8f1d5c4 to c3b5fc8 Apr 8, 2019

@d-nakamichi

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

OK. I changed launch files in khi_*_moveit_config/ based on MoveIt! Setup Assistant.
I also added test files which launch moveit applications.
Thank you.

@matsui-hiro matsui-hiro merged commit 7ac9177 into Kawasaki-Robotics:master Apr 10, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Created
Details
Travis CI - Pull Request Build Passed
Details

@d-nakamichi d-nakamichi deleted the d-nakamichi:khi_prefix branch Apr 11, 2019

d-nakamichi added a commit that referenced this pull request Apr 19, 2019

minor fix (#10)
`rs007l` -> `khi_rs007l`

matsui-hiro added a commit that referenced this pull request Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.