Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias for apcu cache #11

Merged
merged 1 commit into from Jan 14, 2016
Merged

Add alias for apcu cache #11

merged 1 commit into from Jan 14, 2016

Conversation

jiripudil
Copy link
Contributor

doctrine/cache added ApcuCache driver in 1.6. I thought it would be nice to have a config shortcut for the driver.

@enumag
Copy link
Member

enumag commented Jan 13, 2016

@jiripudil
Copy link
Contributor Author

Oh. It seems that doctrine/cache 1.6.0 which added the apcu driver requires PHP >= 5.5, so 5.4 builds fail. What do you suggest? Should I split the test case and skip apcu test on 5.4? (And maybe separate memcache test for PHP 7 build while I'm at it?)

@enumag
Copy link
Member

enumag commented Jan 14, 2016

Hmm. I don't know how exactly skipping works in Nette/Tester so I'm not sure about the best solution.

ping @fprochazka

@fprochazka
Copy link
Member

@jiripudil you can create Extensions.php55.phpt

<?php

/**
 * @testcase
 * @phpversion 5.5
 */

and move it there

@fprochazka
Copy link
Member

I'll fix the build and you can rebase on it then :)

@jiripudil
Copy link
Contributor Author

Rebased :)

@fprochazka
Copy link
Member

@jiripudil you're too fast :P I'm not done yet

@jiripudil
Copy link
Contributor Author

:lol:

@enumag
Copy link
Member

enumag commented Jan 14, 2016

@jiripudil Don't forget to squash. :-)

@fprochazka
Copy link
Member

@jiripudil not that I think about it more, having a separate file is not neccesary :) See the testFunctionalityMemcache

@fprochazka
Copy link
Member

great 👍

fprochazka added a commit that referenced this pull request Jan 14, 2016
@fprochazka fprochazka merged commit 2f599e6 into Kdyby:master Jan 14, 2016
@jiripudil jiripudil deleted the patch-1 branch January 14, 2016 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants