Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #124

Open
wants to merge 2 commits into
base: master
from
Open

Fix build #124

wants to merge 2 commits into from

Conversation

@PavelJurasek
Copy link
Contributor

PavelJurasek commented Sep 9, 2019

Error in SymfonyDispatcher is probably not fixable as this package only (AFAIK) (ab?)uses the interface as a proxy to its own EventManager.

I also believe that the case with Reference being passed to class_exists in EventsExtension won't occur. If someone is able to provide a counter-example, I'll fix that and cover with tests.

I'd love to see a new release being tagged 馃檭

@PavelJurasek

This comment has been minimized.

Copy link
Contributor Author

PavelJurasek commented Sep 9, 2019

Might be worth checking out #120 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.