Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should happen when translating absolute message and providing $domain at same time? #127

Closed
JanMikes opened this issue Sep 4, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@JanMikes
Copy link
Contributor

commented Sep 4, 2016

I was thinking, what should be the result, when trying something like this:

$translator->translate("//messages.someMessage", NULL, [], "something");

Should the result be same as {_messages.something.someMessage}?

Imho throwing exception could be solution as well, what do you think @fprochazka ?

@fprochazka

This comment has been minimized.

Copy link
Member

commented May 15, 2017

Throwing and exception seems reasonable.

@fprochazka fprochazka added the bug label May 15, 2017

@fprochazka fprochazka modified the milestones: v2.4, v2.3 May 15, 2017

@fprochazka

This comment has been minimized.

Copy link
Member

commented May 16, 2017

This might be a BC Break, but IMHO better to break it than having undefined behaviour. It can be always defined later :)

fprochazka added a commit that referenced this issue May 16, 2017

@fprochazka

This comment has been minimized.

Copy link
Member

commented May 16, 2017

@Lexinek thank you for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.