Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dir in config with "\" not working #130

Closed
iNviNho opened this issue Sep 28, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@iNviNho
Copy link

commented Sep 28, 2016

Hey guys,

On production server resources are not loaded if dirs contains \ chars instead of / chars.

This didn't work:

translation:
    dirs: ['%appDir%\Core\lang']

but this works

translation:
    dirs: 
        - %appDir%/Core/lang

Maybe there should be some checking if given path is ok or not (and probably throw exception to let user know that path is invalid because it has invalid chars), what do you think?

@fprochazka fprochazka added the bug label May 15, 2017

@fprochazka fprochazka added this to the v2.3 milestone May 15, 2017

@fprochazka

This comment has been minimized.

Copy link
Member

commented May 15, 2017

Oh wow, this suprised me. I was sure PHP normalizes the paths.

fprochazka added a commit that referenced this issue May 15, 2017

@fprochazka

This comment has been minimized.

Copy link
Member

commented May 15, 2017

@iNviNho thank you for reporting!

@iNviNho

This comment has been minimized.

Copy link
Author

commented May 16, 2017

@fprochazka perfect, no problem, nice fix :)

@fprochazka

This comment has been minimized.

Copy link
Member

commented May 16, 2017

@iNviNho please try the latest release and report if anything breaks :) Enjoy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.