Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed nette 2.4 compatibility #117

Merged
merged 1 commit into from Aug 20, 2016

Conversation

Projects
None yet
6 participants
@matej21
Copy link
Contributor

commented Jul 7, 2016

This change is Reviewable

if (method_exists('Latte\Engine', 'addProvider')) { // Nette 2.4
$def->addSetup('addProvider', ['translator', '@Kdyby\Translation\Translator']);
$def->addSetup('addProvider', ['translator', [$this->prefix('@helpers'), 'getTranslator']])

This comment has been minimized.

Copy link
@fprochazka

fprochazka Jul 11, 2016

Member

Hmm, why not use the service directly? $this->prefix('@default') ? It works with a callback too?

This comment has been minimized.

Copy link
@matej21

matej21 Jul 11, 2016

Author Contributor

I'm not sure :))

@JanTvrdik

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2016

ping

@JanTvrdik

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

double ping!

@matej21 matej21 force-pushed the matej21:fix/nette_24_compat branch from 90f13c9 to 7ded54d Jul 25, 2016

@Attanon

This comment has been minimized.

Copy link

commented Aug 4, 2016

ping

@Salamek

This comment has been minimized.

Copy link

commented Aug 12, 2016

...ping

@clovnrian

This comment has been minimized.

Copy link

commented Aug 19, 2016

ping

@fprochazka fprochazka merged commit 8be1a5b into Kdyby:master Aug 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fprochazka

This comment has been minimized.

Copy link
Member

commented Aug 20, 2016

@matej21 thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.