Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes absolute messages in non-prefixed translator #128

Merged
merged 3 commits into from Mar 8, 2017

Conversation

Projects
None yet
4 participants
@JanMikes
Copy link
Contributor

commented Sep 4, 2016

Fixes #126
Possible fix to #114 (not tested) @medhi please would you mind try it out?

@coveralls

This comment has been minimized.

Copy link

commented Sep 4, 2016

Coverage Status

Coverage increased (+0.06%) to 71.284% when pulling aaa839c on Lexinek:master into f14d9c0 on Kdyby:master.

@medhi

This comment has been minimized.

Copy link

commented Sep 6, 2016

I would, but I don't know how to test a pull request, can you help me?

@JanMikes

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2016

@medhi you can use the pull request repository instead of the vendor's default one and run composer update (thats the way i would do it), update your composer.json like this:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/Lexinek/Translation"
        }
    ],
    "require": {
        "kdyby/translation": "@dev"
    }
}
@medhi

This comment has been minimized.

Copy link

commented Sep 6, 2016

Thanks. Tested and seems fixed.

@JanMikes

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2017

@fprochazka Possible to merge, so i can delete repository Lexinek/Translation please?

@fprochazka

This comment has been minimized.

Copy link
Member

commented Mar 8, 2017

Yeah, this looks reasonable. Thank you guys!

@fprochazka fprochazka merged commit 14ddd26 into Kdyby:master Mar 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 71.284%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.