Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 3.x #137

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
4 participants
@enumag
Copy link
Member

commented Mar 18, 2017

[Closes #118]

@coveralls

This comment has been minimized.

Copy link

commented Mar 18, 2017

Coverage Status

Coverage decreased (-35.6%) to 34.532% when pulling 9612491 on enumag:patch-4 into 14ddd26 on Kdyby:master.

@coveralls

This comment has been minimized.

Copy link

commented Mar 18, 2017

Coverage Status

Coverage decreased (-3.8%) to 66.315% when pulling 73a1548 on enumag:patch-4 into 14ddd26 on Kdyby:master.

@coveralls

This comment has been minimized.

Copy link

commented Mar 18, 2017

Coverage Status

Coverage decreased (-0.08%) to 70.047% when pulling c2bc948 on enumag:patch-4 into 14ddd26 on Kdyby:master.

enumag added some commits Mar 18, 2017

@enumag enumag force-pushed the enumag:patch-4 branch from c2bc948 to 2b56ca6 Mar 18, 2017

@enumag

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2017

@fprochazka The failing test is the same one as in master so it's unrelated to this pull request.

@coveralls

This comment has been minimized.

Copy link

commented Mar 18, 2017

Coverage Status

Coverage decreased (-0.08%) to 70.047% when pulling 2b56ca6 on enumag:patch-4 into 14ddd26 on Kdyby:master.

@aleswita

This comment has been minimized.

Copy link

commented Mar 21, 2017

It's posibble to add dependency on nette/php-generator ~3.0.0 to this pull request?

@enumag

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2017

@aleswita That should be a separate PR in my opinion. Feel free to send one.

@fprochazka fprochazka added this to the v2.3 milestone May 15, 2017

@fprochazka fprochazka added the feature label May 15, 2017

fprochazka added a commit that referenced this pull request May 15, 2017

Allow Symfony 3.x
Fix NeonFileDumper
Fix Translator

[Closes #137] [Closes #118]
@fprochazka

This comment has been minimized.

Copy link
Member

commented May 15, 2017

@enumag Thank you!

@fprochazka

This comment has been minimized.

Copy link
Member

commented May 15, 2017

@aleswita added 0400e8b :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.