Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array loader #139

Merged
merged 1 commit into from Jun 12, 2017

Conversation

Projects
None yet
2 participants
@jtojnar
Copy link
Contributor

commented Jun 12, 2017

Symfony allows loading a translation resource from a PHP array using Symfony\Component\Translation\Loader\ArrayLoader but Kdyby\Translation does not recognize that loader.

This patch adds the loader to the list of loader. Additionally, because the resource value is used as an array key in the Tracy panel, the value had to be serialized.

Support array loader
Symfony allows loading a translation resource from a PHP array using
`Symfony\Component\Translation\Loader\ArrayLoader` but Kdyby\Translation
does not recognize that loader.

This patch adds the loader to the list of loader. Additionally,
because the resource value is used as an array key in the Tracy panel,
the value had to be serialized.

@fprochazka fprochazka merged commit 196e246 into Kdyby:master Jun 12, 2017

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.3%) to 69.834%
Details
Scrutinizer 2 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fprochazka

This comment has been minimized.

Copy link
Member

commented Jun 12, 2017

Awesome, thank you!

@jtojnar jtojnar deleted the jtojnar:array-loader branch Jun 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.