nette 3.1 compatibility #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nette 3.1 compatibility
|
@enumag please can you take a look to this? It fixes master and other PR will have green build too. Thanks! |
enumag
reviewed
Feb 4, 2021
enumag
reviewed
Feb 4, 2021
enumag
reviewed
Feb 4, 2021
|
any news here? |
enumag
reviewed
Feb 9, 2021
enumag
reviewed
Feb 10, 2021
Co-authored-by: Jáchym Toušek <enumag@gmail.com>
|
@vrestihnat you are very close :) please don't give up |
|
I don't give up. I just don't see any more comments so we can close it. |
enumag
approved these changes
Feb 19, 2021
nufue
pushed a commit
to inspire-develop/Translation
that referenced
this pull request
Apr 27, 2022
* nette 3.1 compatibility * latte fix max compatibility version * fix cs * Update .travis.yml * latte/latte 2.10.1 compatibility * fix if not exists latte engine constant * clearing .travis.yml * clearing .gitignore * composer.json - original dependence latte/latte * Update tests/KdybyTests/Translation/LatteExtractorTest.phpt * useless variables in LatteExtractorTest.phpt * CS Squiz.Strings.DoubleQuoteUsage.NotRequired was excluded from Extractor test * Update LatteExtractorTest.phpt * Update ruleset.xml * Update src/DI/TranslationExtension.php Co-authored-by: Jáchym Toušek <enumag@gmail.com> Co-authored-by: Jáchym Toušek <enumag@gmail.com>
nufue
pushed a commit
to inspire-develop/Translation
that referenced
this pull request
Nov 22, 2022
* nette 3.1 compatibility * latte fix max compatibility version * fix cs * Update .travis.yml * latte/latte 2.10.1 compatibility * fix if not exists latte engine constant * clearing .travis.yml * clearing .gitignore * composer.json - original dependence latte/latte * Update tests/KdybyTests/Translation/LatteExtractorTest.phpt * useless variables in LatteExtractorTest.phpt * CS Squiz.Strings.DoubleQuoteUsage.NotRequired was excluded from Extractor test * Update LatteExtractorTest.phpt * Update ruleset.xml * Update src/DI/TranslationExtension.php Co-authored-by: Jáchym Toušek <enumag@gmail.com> Co-authored-by: Jáchym Toušek <enumag@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple adjustments for nette 3.1 and latte 2.10.1 compatibility. Please publish changes.