Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved AcceptHeaderResolver #82

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@enumag
Copy link
Member

commented Jul 16, 2015

Previously suggested here.

@enumag enumag force-pushed the enumag:patch branch from 14ff83f to 6fee3fe Jul 16, 2015

@fprochazka

This comment has been minimized.

Copy link
Member

commented Jul 17, 2015

The build died :-/ Also, if we're copying code from Nette, it might be worth it to copy also the relevant tests. Can you do that please?

@enumag

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2015

Agreed, I'll look into it.

@enumag enumag force-pushed the enumag:patch branch 2 times, most recently from 30ecbd2 to 34f0c76 Jul 17, 2015

if (strlen($locale) > 2) {
$langs[] = substr($locale, 0, 2);
}
}

This comment has been minimized.

Copy link
@enumag

enumag Jul 17, 2015

Author Member

I've changed this part to support locales like en-gb. Is it ok? I'm not sure how it works in Symfony.

This comment has been minimized.

Copy link
@fprochazka

fprochazka Jul 17, 2015

Member

Great idea, fine with me 👍

@enumag

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2015

All done, please review.

@enumag enumag force-pushed the enumag:patch branch from 34f0c76 to 6f93585 Jul 17, 2015

@fprochazka

This comment has been minimized.

Copy link
Member

commented Jul 17, 2015

I love it!

@fprochazka

This comment has been minimized.

Copy link
Member

commented Jul 17, 2015

I've fixed some minor whitespace issue and merged it e4ba0c1, thank you!

@fprochazka fprochazka closed this Jul 17, 2015

@enumag

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2015

@fprochazka Great, thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.