Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation domain to tracy panel #98

Merged
merged 1 commit into from Feb 10, 2016

Conversation

Projects
None yet
2 participants
@enumag
Copy link
Member

commented Feb 7, 2016

No description provided.

@enumag

This comment has been minimized.

Copy link
Member Author

commented Feb 9, 2016

@fprochazka Travis failed but the error doesn't seem related. And I didn't get the same error on localhost. Some tests did fail on localhost though for yet another reason, probably some CRLF issues.

{
$this->untranslated[] = $e;
$this->untranslated[] = array(
'message' => $message,

This comment has been minimized.

Copy link
@fprochazka

fprochazka Feb 10, 2016

Member

ehm, typo?

@fprochazka

This comment has been minimized.

Copy link
Member

commented Feb 10, 2016

@enumag I guess new feature of nette/code-checker :-/

@fprochazka

This comment has been minimized.

Copy link
Member

commented Feb 10, 2016

@enumag fixed, could you please rebase this onto master?

@enumag enumag force-pushed the enumag:patch-untranslated branch from a73866a to 766dc44 Feb 10, 2016

@enumag

This comment has been minimized.

Copy link
Member Author

commented Feb 10, 2016

@fprochazka Thanks! Done with the rebase.

@fprochazka

This comment has been minimized.

Copy link
Member

commented Feb 10, 2016

Looks good, thanks!

fprochazka added a commit that referenced this pull request Feb 10, 2016

Merge pull request #98 from enumag/patch-untranslated
Add translation domain to tracy panel

@fprochazka fprochazka merged commit c54524e into Kdyby:master Feb 10, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@enumag

This comment has been minimized.

Copy link
Member Author

commented Feb 10, 2016

You're welcome. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.