Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster compiling of extension #99

Merged
merged 1 commit into from Mar 8, 2016

Conversation

Projects
None yet
2 participants
@MartkCz
Copy link
Contributor

commented Mar 6, 2016

When I using only one loader, other loaders unnecessarily looking for resources.

Solution:

translation:
    loaders: [neon]

Enables only neon loader => compiling is ~10x faster than before.

Statistics:
All loaders: ~ 2690 ms
One loader: ~ 262 ms

@fprochazka

This comment has been minimized.

Copy link
Member

commented Mar 8, 2016

That is pretty awesome!

fprochazka added a commit that referenced this pull request Mar 8, 2016

Merge pull request #99 from AntikCz/master
Faster compiling of extension

@fprochazka fprochazka merged commit 61d60c8 into Kdyby:master Mar 8, 2016

2 checks passed

Scrutinizer 1 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fprochazka

This comment has been minimized.

Copy link
Member

commented Mar 8, 2016

Thank you!

Just an idea: do you think the whitelist could be generated automatically based on found resources? The container is doing compile-time resolution, so the default loaders might not be all of them, but only those that were needed during compilation.

If you have some more time, it would be great if you could prepare a PR for that :)

@MartkCz

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2016

I hope I understand. I will take a look at it and will try to send PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.