Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upBreak out check_external_links into a command-line flag or subcommand #381
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Freaky
Aug 25, 2018
Contributor
Also: Reason: Link https://crates.io/crates/rand is not valid: 404 Not Found
I think this was an Accept-Content thing.
|
Also: I think this was an |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Keats
Aug 25, 2018
Owner
For crates.io: I mentioned it on the post for 0.4 but it behaves badly and always return 404. I'm tempted to replace my crates.io use with https://crates.rs/
It's also quite frustrating for it to just stop on the first error, necessitating running it repeatedly, particularly when using the command for the first time.
I agree this should be improved, instead of stopping at one error it should check all links and report all the ones not working. The issue is that it is currently part of the rendering which stops when it sees an error.
I'm not sure about having a separate command for that but i like the flag idea
|
For crates.io: I mentioned it on the post for 0.4 but it behaves badly and always return 404. I'm tempted to replace my crates.io use with https://crates.rs/
I agree this should be improved, instead of stopping at one error it should check all links and report all the ones not working. The issue is that it is currently part of the rendering which stops when it sees an error. I'm not sure about having a separate command for that but i like the flag idea |
Freaky commentedAug 25, 2018
•
edited
Edited 1 time
-
Freaky
edited Aug 25, 2018 (most recent)
-
Freaky
created Aug 25, 2018
check_external_linksis very expensive, and isn't even recommended to be left on even in the docs. I think it would be more practical as either a run-time argument tobuild, or ideally as its own subcommand.It's also quite frustrating for it to just stop on the first error, necessitating running it repeatedly, particularly when using the command for the first time.