-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove ring #318
remove ring #318
Conversation
Can you add a CI setup for it? |
@chenzhenjia Are you still working on that? If not I would like to take over |
I don't have time right now, if you have time you can take over |
I also need this. @Keats do you have an example of a CI setup? I can take a stab if I have something to work off of |
I don't have an example, but it should not be too hard to find one looking at Rust projects with wasm support |
I added one in #345. I'm now wondering if we should just ditch ring vs using the pure rust sha/rsa etc crates entirely? |
If someone can try a PR that removes ring, that'd be great. I'll do it otherwise but no idea on when |
# Conflicts: # Cargo.toml # examples/custom_header.rs # examples/validation.rs # src/crypto/ecdsa.rs # src/crypto/rsa.rs # src/jwk.rs
@Keats The ring has been completely removed |
@Keats All steps of ci have been successful |
Running
It is a result of this example expecting method |
fixed |
@Keats hi.Any questions about the pull request? |
So there is another PR replacing ring: #377 I'm not sure what to do tbh, I don't want multiple backends and I don't think the rust crypto crates are FIPS certified right? |
Although these libraries are not FIPS certified, their security should not be an issue. |
No I completely understand the benefits. It's just that not being FIPS certified means some people can't use the crate at all. |
What is the rationale for not supporting multiple backends? Other crates, such as |
See #399 If someone wants to do a PR having both, sure |
I understand. If |
No description provided.