New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests (not unit test, the tester feature) #62

Closed
Keats opened this Issue Oct 4, 2016 · 4 comments

Comments

2 participants
@Keats
Copy link
Owner

Keats commented Oct 4, 2016

Left to add:

  • divisibleby
  • iterable (basically tuples and arrays, but in a way strings are iterable too hmm)

All testers are in src/testers.rs

@SergioBenitez

This comment has been minimized.

Copy link
Contributor

SergioBenitez commented Oct 8, 2016

Are there any other ones that seem prudent to add?

@Keats

This comment has been minimized.

Copy link
Owner

Keats commented Oct 8, 2016

divisibleby can probably be added looking at http://jinja.pocoo.org/docs/dev/templates/#builtin-tests.
iterable could be added as well to check if it's an array

@SergioBenitez

This comment has been minimized.

Copy link
Contributor

SergioBenitez commented Oct 8, 2016

It might be better to add a modulo % operator instead of divisibleby.

iterable sounds okay, but then we should add a test for other types, like integer, float, null, etc.

@SergioBenitez

This comment has been minimized.

Copy link
Contributor

SergioBenitez commented Oct 8, 2016

Oh, looks like some of those are in #63 already!

@Keats Keats changed the title Adding tests Adding tests (not unit test, the tester feature) Nov 18, 2016

@Keats Keats added this to the 0.5 milestone Dec 1, 2016

@Keats Keats modified the milestones: 0.6, 0.5 Dec 18, 2016

@Keats Keats closed this Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment