Adding tests (not unit test, the tester feature) #62

Closed
Keats opened this Issue Oct 4, 2016 · 4 comments

Projects

None yet

2 participants

@Keats
Owner
Keats commented Oct 4, 2016 edited

Left to add:

  • divisibleby
  • iterable (basically tuples and arrays, but in a way strings are iterable too hmm)

All testers are in src/testers.rs

@SergioBenitez
Contributor

Are there any other ones that seem prudent to add?

@Keats
Owner
Keats commented Oct 8, 2016

divisibleby can probably be added looking at http://jinja.pocoo.org/docs/dev/templates/#builtin-tests.
iterable could be added as well to check if it's an array

@SergioBenitez
Contributor

It might be better to add a modulo % operator instead of divisibleby.

iterable sounds okay, but then we should add a test for other types, like integer, float, null, etc.

@SergioBenitez
Contributor

Oh, looks like some of those are in #63 already!

@Keats Keats changed the title from Adding tests to Adding tests (not unit test, the tester feature) Nov 18, 2016
@Keats Keats added this to the 0.5 milestone Dec 1, 2016
@Keats Keats modified the milestone: 0.6, 0.5 Dec 18, 2016
@Keats Keats closed this Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment