New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix include whitespace #72

Closed
Keats opened this Issue Nov 15, 2016 · 2 comments

Comments

1 participant
@Keats
Copy link
Owner

Keats commented Nov 15, 2016

Looking at templates/included.html we need to do weird things to keep indentation. Have a look and see if it's easily fixable

@Keats Keats modified the milestone: 0.5 Nov 29, 2016

@Keats

This comment has been minimized.

Copy link
Owner

Keats commented Dec 13, 2016

So it's a bit more complicated than expected:
Indentation is actually correct BUT we don't get the indentation from before the include on the the lines of the include other than the first.
When we are rendering the include, we don't know the indentation level so there's no way to do it manually.

Removing from 0.5 milestone, seems like a pain to fix and probably not worth it. If anyone has a good idea on that, please send a PR!

@Keats Keats removed this from the 0.5 milestone Dec 13, 2016

SeiryuZ added a commit to SeiryuZ/tera that referenced this issue Dec 16, 2016

This was referenced Dec 16, 2016

Keats added a commit that referenced this issue Dec 17, 2016

@Keats

This comment has been minimized.

Copy link
Owner

Keats commented Nov 24, 2017

Fixed as of 0.11.0-beta as you can control whitespace

@Keats Keats closed this Nov 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment