Search library also in split APKs.

[michalsrb]

The library may be placed in a split APK. This happens for example when using
the dynamic delivery.

Fixes #44.

[michalsrb]

Note that appInfo.splitSourceDirs may be null on some devices, the documentation does not mention it.

[StainlessStlRat]

Will this be merged soon?

[chriswiesner]

any update?

[michalsrb]

The travis build failed because of ">" character inside comment. The comment was there already.

[philippb]

@michalsrb thanks for the PR. Sorry I just saw this. We will look at this by the end of this week or beginning of next one the latest.

Looking at it briefly:

• could you please fix the existing tests and add new tests for the new behavior.
• is there documentation that we can link in here the describes the designed behavior of multi APK apps?

How does it look in production for you?

[philippb]

@emarc-m Did you have a chance to look at this?

[michalsrb]

could you please fix the existing tests and add new tests for the new behavior.

The ApkLibraryInstallerTest was failing because apparently the android.util.Pair intentionally behaves badly in unit tests. (stackoverflow)
So I replaced it with custom private class and the test passes now.

is there documentation that we can link in here the describes the designed behavior of multi APK apps?

Here is documentation that describes a bit how Google Play splits the APKs:
https://developer.android.com/guide/app-bundle/configure

I don't know if there is something better.

How does it look in production for you?

It works well. I am getting small amount of failures, but I have been getting those before as well. I suspect those may be people who install APKs from 3rd party sources with wrong ABI.

[sdeff]

Does anyone know how long it might take until this PR will be merged?

[emarc-m]

Thanks for the work! Minor comments.

@michalsrb do you think it's possible to include a unit test for #sourceDirectories(...) wherein the first if branch will be executed?

[emarc-m]

please move { to the previous line such that appInfo.splitSourceDirs.length != 0) {

[emarc-m]

jniNameInApk will not be null

[amatsegor]

@michalsrb your PR is so waited by lots of developers
Could you please fix these 2 tiny tips from @emarc-m so he can accept the PR ?

[michalsrb]

I made the small changes. I don't know how to mock the Build.VERSION.SDK_INT to make the unit test.

[philippb]

I merged this PR and I'm cutting a new version.

I suggest for the unit testing portion that we create something like an SDK manager class that has a meshing like minSdkVersion() that returns Build.VERSION.SDK_INT. Then we can mock the entire class for testing purpose.

Unit tests should be in a separate PR to this.
cc @emarc-m @michalsrb

[amatsegor]

Awesome, thanks! So is there any nightly builds of Relinker or when should we expect a new release?

[philippb]

Made a new release: 1.3.0 with split APK support.
Thank you everyone!