Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandSystem: Tabcompletion and bug fixes #65

Merged
merged 12 commits into from
May 24, 2021
Merged

CommandSystem: Tabcompletion and bug fixes #65

merged 12 commits into from
May 24, 2021

Conversation

DSeeLP
Copy link
Contributor

@DSeeLP DSeeLP commented Apr 29, 2021 •
edited
Loading

Changelog

  • Fixed maven build
  • Fixed bug that only the root node of a command was executed
  • Added Tabcompletion
  • Added boolean argument to KTestCommand
  • Fixed bug that the complete function of BooleanArgument always returned nothing

Edit:

  • Bumped Kotlin version to 1.5.0
  • Bumped KommonCommand to 0.1.1
  • Fixed bug that tab completion did not respect the checkAccess method

@DSeeLP
Fixed NPE when KommonCommand fails to parse the command
05e1ef4 
Signed-off-by: DSeeLP <46624152+DSeeLP@users.noreply.github.com>
@DSeeLP
Fixed maven build
d38b3d6 
Signed-off-by: DSeeLP <46624152+DSeeLP@users.noreply.github.com>
@DSeeLP
Fixed issue that only the root node could be executed.
6d84225 
Signed-off-by: DSeeLP <46624152+DSeeLP@users.noreply.github.com>
@DSeeLP
Added Tab-Completion
daa447f 
Signed-off-by: DSeeLP <46624152+DSeeLP@users.noreply.github.com>
@DSeeLP
Added boolean argument to KTestCommand
7a06038 
Signed-off-by: DSeeLP <46624152+DSeeLP@users.noreply.github.com>
@DSeeLP
Fixed issue that the complete function always returned nothing
edfbafc 
Signed-off-by: DSeeLP <46624152+DSeeLP@users.noreply.github.com>
@PXAV
Copy link
Member

PXAV commented Apr 29, 2021

Hi, thanks for adding an update that quickly! Love the idea of how tab-completion was implemented.

As I have also done some changes to the pom files to fix #63, I'll resolve the conflicts as soon as the new update is ready as well. I expect this to happen within the next few days.

DSeeLP added 4 commits May 2, 2021 11:05
@DSeeLP
Bumped KommonCommand version to 0.1.1
ffc7d70 
Signed-off-by: DSeeLP <46624152+DSeeLP@users.noreply.github.com>
@DSeeLP
Command completer now respects the checkAccess method
0465faf 
Signed-off-by: DSeeLP <46624152+DSeeLP@users.noreply.github.com>
@DSeeLP
Bumped Kotlin version to 1.5.0
e9a3be4 
Signed-off-by: DSeeLP <46624152+DSeeLP@users.noreply.github.com>
@DSeeLP
Bumped KommonCommand to version 0.2.2
b98a695 
Signed-off-by: DSeeLP <46624152+DSeeLP@users.noreply.github.com>
@PXAV PXAV added commands Something related to the command handling system enhancement New feature or request labels May 24, 2021
@PXAV PXAV changed the base branch from command to development May 24, 2021 15:16
@PXAV PXAV merged commit b485ccd into KelpFramework:development May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PXAV PXAV PXAV approved these changes

Assignees
No one assigned
Labels
commands Something related to the command handling system enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DSeeLP @PXAV