From 4c0e47451b57ea584ff5c84c31115924e2ced7ab Mon Sep 17 00:00:00 2001 From: John Duprey Date: Wed, 3 Jul 2024 18:01:57 -0400 Subject: [PATCH 1/2] Cleanup comments, add refresh --- src/views/cipp/ExtensionMappings.jsx | 43 ++-------------------------- 1 file changed, 3 insertions(+), 40 deletions(-) diff --git a/src/views/cipp/ExtensionMappings.jsx b/src/views/cipp/ExtensionMappings.jsx index 04665d1cfdee..c7bffa53f624 100644 --- a/src/views/cipp/ExtensionMappings.jsx +++ b/src/views/cipp/ExtensionMappings.jsx @@ -40,20 +40,6 @@ export default function ExtensionMappings({ type, fieldMappings = false, autoMap setMappingValue({}) }) } - /*const onNinjaOrgsSubmit = () => { - const originalFormat = ninjaMappingsArray.reduce((acc, item) => { - acc[item.Tenant?.customerId] = { label: item.ninjaName, value: item.ninjaId } - return acc - }, {}) - - setNinjaOrgsExtensionconfig({ - path: 'api/ExecExtensionMapping?AddMapping=NinjaOrgs', - values: { mappings: originalFormat }, - }).then(() => { - listNinjaOrgsBackend({ path: 'api/ExecExtensionMapping?List=NinjaOrgs' }) - setMappingValue({}) - }) - }*/ const onOrgsAutomap = async (values) => { if (autoMapSyncApi) { @@ -89,32 +75,6 @@ export default function ExtensionMappings({ type, fieldMappings = false, autoMap }) } - /*const onHaloAutomap = () => { - const newMappings = listBackendHaloResult.data?.Tenants.map( - (tenant) => { - const haloClient = listBackendHaloResult.data?.HaloClients.find( - (client) => client.name === tenant.displayName, - ) - if (haloClient) { - console.log(haloClient) - console.log(tenant) - return { - Tenant: tenant, - haloName: haloClient.name, - haloId: haloClient.value, - } - } - }, - //filter out any undefined values - ).filter((item) => item !== undefined) - setHaloMappingsArray((currentHaloMappings) => [...currentHaloMappings, ...newMappings]).then( - () => { - listHaloBackend({ path: 'api/ExecExtensionMapping?List=Halo' }) - }, - ) - setHaloAutoMap(true) - }*/ - useEffect(() => { if (listMappingBackendResult.isSuccess) { setMappingArray( @@ -232,6 +192,9 @@ export default function ExtensionMappings({ type, fieldMappings = false, autoMap columns={columns} data={mappingArray} isModal={true} + refreshFunction={() => + listMappingBackend({ path: `api/ExecExtensionMapping?List=${type}` }) + } /> ) } From 018b0d09aac940701833d72c66c0f5a37774346c Mon Sep 17 00:00:00 2001 From: John Duprey Date: Fri, 5 Jul 2024 12:39:42 -0400 Subject: [PATCH 2/2] Fix automapping --- src/views/cipp/ExtensionMappings.jsx | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/views/cipp/ExtensionMappings.jsx b/src/views/cipp/ExtensionMappings.jsx index c7bffa53f624..d2fc8c48dbd2 100644 --- a/src/views/cipp/ExtensionMappings.jsx +++ b/src/views/cipp/ExtensionMappings.jsx @@ -52,16 +52,17 @@ export default function ExtensionMappings({ type, fieldMappings = false, autoMap }) } - const newMappings = listMappingBackendResult.data?.Tenants.map((tenant) => { + var newMappings = [] + listMappingBackendResult.data?.Tenants.map((tenant) => { const company = listMappingBackendResult.data?.Companies.find( (client) => client.name === tenant.displayName, ) - if (company) { - return { + if (company !== undefined && !mappingArray.find((item) => item.companyId === company.value)) { + newMappings.push({ Tenant: tenant, companyName: company.name, companyId: company.value, - } + }) } }) setMappingArray((currentMappings) => [...currentMappings, ...newMappings]) @@ -87,7 +88,7 @@ export default function ExtensionMappings({ type, fieldMappings = false, autoMap })), ) } - }, [listMappingBackendResult]) + }, [listMappingBackendResult, setMappingArray]) const Actions = (row, rowIndex, formatExtraData) => { return (