Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpotBugsHtmlReport: getting file from path should happen in getter #37

Closed

Conversation

@rpalcolea
Copy link
Contributor

rpalcolea commented Jan 9, 2020

SpotBugsHtmlReport: getting file from path should happen in getter instead of setter to prevent resolving a configuration and slow/break a build that has opinions in resolution strategy.

This should fix #33

rpalcolea added 2 commits Jan 9, 2020
…stead of setter to prevent resolving a configuration and slow/break a build that has opinions in resolution strategy. Fixes
@rpalcolea

This comment has been minimized.

Copy link
Contributor Author

rpalcolea commented Jan 9, 2020

Build failed becase of sonar:

> Task :sonarqube FAILED
21 actionable tasks: 21 executed
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sonarqube'.
> You're not authorized to run analysis. Please contact the project administrator.

if (spotbugs.isPresent()) {
File jar = spotbugs.get();
logger.debug(
"Specified stylesheet ({}) found in spotbugs configuration: {}",

This comment has been minimized.

Copy link
@KengoTODA

KengoTODA Jan 11, 2020

Owner

At this moment we're not sure that the spotbugs jar file contains specified stylesheet or not, right?
I feel this log message is not so intuitive.

@KengoTODA

This comment has been minimized.

Copy link
Owner

KengoTODA commented Jan 11, 2020

I've disabled SonarQube since it's under maintenance. Merge the latest origin/master then the build should pass.

@KengoTODA

This comment has been minimized.

Copy link
Owner

KengoTODA commented Jan 13, 2020

Created #45 with a functional test to reproduce.

@KengoTODA KengoTODA closed this Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.