Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikipedia 进入阅读模式再退出后, 字号变小 #125

Closed
reklanirs opened this issue Sep 28, 2017 · 18 comments

Comments

@reklanirs
Copy link

commented Sep 28, 2017

No description provided.

@Kenshin

This comment has been minimized.

Copy link
Owner

commented Sep 29, 2017

我随便找了一页,比如 https://zh.wikipedia.org/wiki/%E4%BA%8E%E8%B0%A6
前后对比了一下,并没有问题,在你这里是每页都有问题吗?最好告知运行环境。 😀

@Kenshin Kenshin added the notice label Sep 29, 2017

@reklanirs

This comment has been minimized.

Copy link
Author

commented Sep 29, 2017

进入阅读模式前:
image

进入阅读模式再退出后:
image

我也觉得很奇怪... 记得之前并没有这个问题
随便在csdn上找了篇文章试了试, 没有问题
环境是OSX10.11.6, chrome canary 63.0.3218.0

@Kenshin

This comment has been minimized.

Copy link
Owner

commented Sep 29, 2017

我的截图

image

image


每个页面的情况都不一样,不代表 csdn 没问题,wikipedia 也没问题。
但我这边的截图是没有问题的...
我的 Chrome 61.0.3163.100 比你的版本低。

@reklanirs

This comment has been minimized.

Copy link
Author

commented Sep 29, 2017

如果只是特例就先无视这个issue吧.. 说不定是chrome canary的bug来着
如果过几天问题还在我再汇报

@airycanon

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2017

我这边测试也没有重现。
Ubuntu 17.04
Chromium 61.0.3163.79

@Kenshin

This comment has been minimized.

Copy link
Owner

commented Sep 30, 2017

@airycanon
谢谢提示~ 或许是 63 的问题,亦或 61 的问题。 😉

@dreacter

This comment has been minimized.

Copy link

commented Oct 1, 2017

我的测试重现了问题。
具体环境Win 10 x64,Chrome 版本 61.0.3163.100 (x64)。

@Kenshin

This comment has been minimized.

Copy link
Owner

commented Oct 1, 2017

@dreacter
哪个 url 还是每个页面?

@dreacter

This comment has been minimized.

Copy link

commented Oct 1, 2017

(wikipedia的)所有页面都会变小。

@Kenshin

This comment has been minimized.

Copy link
Owner

commented Oct 1, 2017

@dreacter
这就奇怪了, Win / Mac 61 版我都测试过…

@dreacter

This comment has been minimized.

Copy link

commented Oct 1, 2017

试着抓了几张图,不知道有没有帮助。。。
问题似乎是图中的“style="font-size: 70%!important'"”导致的。
未使用simpread:
1
使用阅读模式时:
default

退出阅读模式后:

2

@Kenshin

This comment has been minimized.

Copy link
Owner

commented Oct 1, 2017

@dreacter
好,会有帮助的。 👍

@reklanirs

This comment has been minimized.

Copy link
Author

commented Oct 8, 2017

过了一周, chrome更新了两回, 问题还在 ╮( ̄▽ ̄)╭
来源也发现了: 进入阅读模式后, "字体大小"设为"正常"时, 退出后页面字体显示正常;
"字体大小"设为"增大", 退出后页面字体变小, html属性里多出一个style="font-size: 70%!important"
"字体大小"设为"减小", 退出后页面字体变小, html属性里多出一个style="font-size: 58%!important"

(p.s. 看了下, 多出来的这个style就是阅读模式里调节字体大小时添加的style, 正常大小为style="font-size: 62.5%!important", 不过只有设为"正常"大小时退出阅读模式会把这个style属性删掉)

@Kenshin Kenshin added bug and removed notice labels Oct 9, 2017

@Kenshin

This comment has been minimized.

Copy link
Owner

commented Oct 9, 2017

@reklanirs
okay 我再确认下这个问题~

@airycanon

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2017

https://github.com/Kenshin/simpread/blob/master/src/service/stylesheet.js#L93
这里把 $( "html" ) 改成 $( "sr-read" ) 是不是就可以了?

@Kenshin

This comment has been minimized.

Copy link
Owner

commented Oct 9, 2017

@airycanon
之前的确有过这个问题,但应该修复了,我再确认下。
这几天在忙别的事情,稍晚些会 merge 你的 pr ~ 😢

@Kenshin

This comment has been minimized.

Copy link
Owner

commented Oct 19, 2017

@reklanirs
@dreacter
的确是一个 Bug,已 Fixed,将会随着 1.0.4 一起发布,感谢反馈~
PS:我之前没有发现的原因是,没有将字体大小改为 最大,故而无法重现。 😂

@airycanon

这里把 $( "html" ) 改成 $( "sr-read" ) 是不是就可以了?

并不会解决问题,因为只有把 font-size: 70%!important; 放到 <html> 里面才会生效。

@Kenshin

This comment has been minimized.

Copy link
Owner

commented Oct 24, 2017

简悦 1.0.4 已发布,已解决此问题,将关闭 issues 。

@Kenshin Kenshin closed this Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.