Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

会自动为页面添加css #81

Closed
LLLLevi-y opened this issue Sep 5, 2017 · 10 comments
Closed

会自动为页面添加css #81

LLLLevi-y opened this issue Sep 5, 2017 · 10 comments
Labels
bug

Comments

@LLLLevi-y
Copy link

假如一开启插件就会自动添加一大堆css，如何禁止他不添加css
@Kenshin
Copy link
Owner

Kenshin commented Sep 5, 2017

这些 CSS 在未开启阅读模式时不会对当前页面生效。

目前有什么影响吗？如果有的话，下个版本可以增加个黑名单。

@LLLLevi-y
Copy link
Author

还是会生效的，我在控制台看到，无论阅读模式是否开启，这些CSS还是添加进去了，我自己开发的时候受到了影响，不知道为什么。

@Kenshin
Copy link
Owner

Kenshin commented Sep 5, 2017 •
edited
Loading

的确如你所说，即便不开启阅读模式这些 CSS 也是存在的。
这些 CSS 并没有污染 <body> ，地址在
https://github.com/Kenshin/simpread/tree/master/src/assets/css

或许有漏网之鱼？如果方便的话可以告知受到了什么样的污染？

或许，考虑下个版本需要改善这个地方。

@LLLLevi-y
Copy link
Author

或许是我的变量名和你的变量名重叠了，应该是这样。

@Kenshin
Copy link
Owner

Kenshin commented Sep 5, 2017

我的名字已经很特别了 😓 哪个名字？

@LLLLevi-y
Copy link
Author

可能是有一个carousel的变量名。。。反正我把他全删了就没事了~

@Kenshin
Copy link
Owner

Kenshin commented Sep 5, 2017

hmm…
carousel 应该之在 option 才对，明天我检查下吧。
你把疑似的名字告诉我。

@LLLLevi-y
Copy link
Author

暂时只发现这个~~

@Kenshin
Copy link
Owner

Kenshin commented Sep 6, 2017

的确是 carousel 造成的，我先记 bug 了，Fixed 后跟下个版本一起发布。如果对你的项目有影响的话，要不你先改个名字，要不暂时不要使用 简悦 。

@Kenshin Kenshin added the bug label Sep 6, 2017
@Kenshin Kenshin mentioned this issue Sep 15, 2017
Closed
@Kenshin
Copy link
Owner

Kenshin commented Oct 24, 2017

简悦 1.0.4 已发布，已解决此问题，将关闭 issues 。

@Kenshin Kenshin closed this as completed Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kenshin @LLLLevi-y