Post typography.

[zzap]

As per @mapk suggestions:

• post title restyled
• reading time moved

I also did some typography fixes for post content and changed markup to get structure closer to one found in other Handbooks.

Screenshot:

[joyously]

I don't understand the concept of putting the reading time at the bottom.
It seems like it should be at the top or not at all. In fact, maybe it should be on the archive page by the title link and not on the post itself.

[zzap]

I do agree it's useless below post and that it should be on archives (its position should be another issue, imo).

I moved it at the bottom only because it was requested to be removed from the top and didn't want to remove it completely 😄

[mapk]

If we want to keep reading time (I don't think it's important for documentation reading), then we should definitely move it back to the top.

I think removing it altogether is perfectly okay. People aren't necessarily reading for pleasure when they get to HelpHub. And technical writings will very in length of reading depending on the proficiency of the person's understanding.

[mrxkon]

I'm on the same spec with @mapk on this. Reading time is always meant to be somewhere along with the title in general. But on 'help' docs is actually either not-important or miss-leading even to some people as they might think ( although not stated anywhere ) that oh hm it says 1 minute so I'll fix it in 2 minutes.

I'd suggest to remove it completely, having time on documents in general seems like more of a stress factor to me than a relief one.

[atachibana]

Post Title:
Yes, it seems the same with Handbooks. I like this one!

Reading Time:
I have the same opinion with others.
Especially for non-native English speaker, that number is just number. :-)

[zzap]

OK, looks like we decided to remove Reading Time completely. I will update PR.

[mayeenulislam]

Style seems good to me, though I's not a listed reviewer. But an issue:

wp4.css is disabling the content's bottom margin for <p> tags inside .entry-content:

We should fix the precedence of the CSS files. To me, the declaration of wp4.css is kinda normalizing things. We should load it before style.css

[zzap]

To me, the declaration of wp4.css is kinda normalizing things. We should load it before style.css

wp4.css is loaded altogether with wporg header in header.php

It should be loaded before our style.css but that is not possible in this setup. That is the reason I didn't really touch those things which will be inherited once HelpHub is inside .org and order of stylesheets correct.

Most of all, this pull request is about styling post title properly.

[mayeenulislam]

Most of all, this pull request is about styling post title properly.

The pull request met that part completely and with no conflict, is ready to merge.

[ntwb]

With this whole file being removed it should also be removed fro import in style.scss:

https://github.com/Kenshino/HelpHub/blob/master/themes/helphub/sass/style.scss#L97

[zzap]

It is removed.

https://github.com/Kenshino/HelpHub/pull/146/files#diff-ae43b438d537cbe2c607d5f83ed69e79

[ntwb]

Ha, I looked twice, my bad, must still be in holiday mode ;)

[zzap]

Fixes #109