Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #59: Have kepconvert produce CSV output #69

Merged
merged 2 commits into from Jul 31, 2017
Merged

Conversation

@PierreZ
Copy link
Contributor

@PierreZ PierreZ commented Jul 27, 2017

Don't hesitate to correct me, I'm not used to Python 馃槃

@codecov
Copy link

@codecov codecov bot commented Jul 27, 2017

Codecov Report

Merging #69 into master will increase coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   12.97%   13.57%   +0.59%     
==========================================
  Files          48       49       +1     
  Lines        9295     9322      +27     
==========================================
+ Hits         1206     1265      +59     
+ Misses       8089     8057      -32
Impacted Files Coverage 螖
pyke/kepconvert.py 18.14% <100%> (+13.85%) 猬嗭笍
pyke/tests/test_kepconvert.py 100% <100%> (酶)
pyke/kepio.py 25.27% <0%> (+0.18%) 猬嗭笍
pyke/kepmsg.py 80.95% <0%> (+9.52%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e533441...48a55c1. Read the comment docs.

@mirca mirca requested review from barentsen and gully Jul 27, 2017
@mirca
Copy link
Member

@mirca mirca commented Jul 27, 2017

Hi @PierreZ, thank you very much for your contribution!
Would you be able to provide a minimal unit test just to make sure your changes work as intended?
For examples on unit tests, you can check out the tests folder.

Thanks again! 馃憤

@PierreZ
Copy link
Contributor Author

@PierreZ PierreZ commented Jul 28, 2017

I'll add some unit tests 馃憤

@PierreZ PierreZ force-pushed the PierreZ:csv branch from 5a8d20d to f049169 Jul 29, 2017
@PierreZ PierreZ force-pushed the PierreZ:csv branch from f049169 to 48a55c1 Jul 29, 2017
@mirca
Copy link
Member

@mirca mirca commented Jul 30, 2017

This looks solid, thanks @PierreZ!

@mirca mirca merged commit b8be1d2 into KeplerGO:master Jul 31, 2017
3 checks passed
3 checks passed
@codecov
codecov/patch 100% of diff hit (target 12.97%)
Details
@codecov
codecov/project 13.57% (+0.59%) compared to e533441
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants