New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Science becomes permanently stuck inflight if vessel is destroyed #554
Comments
I'm not sure if this affects all science experiments or even if the step of transferring data is necessary, this is just a description of how I encountered the issue. |
I'm guessing this may be because this callback is never called when the craft is completely destroyed? |
Ah, this seems likely. Maybe we need to attach to |
I can't test right now but it is very unlikely that it is "permanently stuck", as the in flight data is recalculated from scratch on every deserialization/serialization cycle by iterating on all parts. Are you sure the parts are actually destroyed ? Data sitting on parts/vessels marked as "debris" will still count. There can be some cases of the inflight science staying a while (until you go trough a reload / scene change) if it was on a vessel that was destroyed while unloaded. Unfortunately there is no reliable way to detect that without risking removing twice the science (and other more harmful consequences). Edit : this said, we probably should implement some "pre-clearing" method in the |
Hmm. Not the case for me, as the vessel was loaded when destroyed. I'll fire it up again tonight and try to learn more about the reproduction steps.
Ah, where is this code? |
… is destroyed Previously you had to go trough a serialization/deserialization cycle (scene change)
Steps to reproduce:
The Materials Study science value for whatever biome you ran it in will still show up as "inflight".
The text was updated successfully, but these errors were encountered: