Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fix for the greedy arrows class. #172

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@tschallacka
Copy link

commented Jun 6, 2019

According to https://github.com/KevinBatdorf/liquidslider/blob/master/src/js/jquery.liquid-slider.js#L173-L176 all liquidslider items are wrapped in a div with ls-wrapper.
I added this as a prefix to the arrow class due to the fact that this greedy arrow selector messes up other parts of the site without a liquid slider
By adding the prefix the arrows should stay within their designated area.

image

Added a fix for the greedy arrows class.
According to https://github.com/tschallacka/liquidslider/blob/master/src/js/jquery.liquid-slider.js#L173-L176 all liquidslider items are wrapped in an item with ls-wrapper.
I added this as a prefix to the arrow class due to the fact that this greedy arrow selector messes up other parts of the site without a liquid slider
By adding the prefix the arrows should stay within their designated area.
@KevinBatdorf
Copy link
Owner

left a comment

Thanks!

@KevinBatdorf KevinBatdorf merged commit b7b8ff6 into KevinBatdorf:master Jun 6, 2019

@tschallacka

This comment has been minimized.

Copy link
Author

commented Jun 6, 2019

You're fast

@KevinBatdorf

This comment has been minimized.

Copy link
Owner

commented Jun 6, 2019

Was an easy fix. The code hasn't been changed much in 4 years though :D

Maybe I should do a rewrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.