Refactored libs/core and tests #150

Merged
merged 2 commits into from Mar 27, 2017

Conversation

Projects
None yet
2 participants
@kakts
Contributor

kakts commented Mar 16, 2017

PR Summary

Refactored files.

  • Deleted unused variables/functions/comments
  • Fixed some tests.
  • Fixed some if-nest logic.

Lint Results

Before

$ grunt jshint
>> 53 errors in 43 files

After

$ grunt jshint
>> 36 errors in 43 files

kakts added some commits Mar 16, 2017

Refactored libs/core.
- Deleted unused variables/functions/comments
Refactored:
- Fix some tests.
@Keyang

Keyang approved these changes Mar 27, 2017

@Keyang Keyang merged commit a027cea into Keyang:master Mar 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Keyang

This comment has been minimized.

Show comment
Hide comment
@Keyang

Keyang Mar 27, 2017

Owner

Thanks for the refactor work.

~Keyang

Owner

Keyang commented Mar 27, 2017

Thanks for the refactor work.

~Keyang

@kakts

This comment has been minimized.

Show comment
Hide comment
@kakts

kakts Mar 27, 2017

Contributor

Thank you for reviewing.

Contributor

kakts commented Mar 27, 2017

Thank you for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment