Ab#77142 #7
Ab#77142 #7
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for renewing certificates bound to the HTTPS server in Fortigate, expanding the existing capability to manage bound certificates. The implementation adds new API endpoints to check and update HTTPS server bindings, ensuring certificate replacements maintain service continuity.
- Added HTTPS server certificate binding support to complement existing VPN certificate management
- Upgraded BouncyCastle.Cryptography from v2.0.0 to v2.6.2
- Enhanced documentation with improved formatting, corrected spelling, and clearer instructions for store type creation and certificate store management
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Fortigate/FortigateStore.cs | Added HttpsServerUsage() and UpdateHttpsServerUsage() methods to query and update HTTPS server certificate bindings; updated Insert() method to handle HTTPS certificate replacement |
| Fortigate/Api/HttpsUsage.cs | New API model classes (HttpsUsage, HttpUsageRequest, OriginKey) for HTTPS server certificate binding operations |
| Fortigate/Fortigate.csproj | Updated BouncyCastle.Cryptography package reference from v2.0.0 to v2.6.2 |
| README.md | Documented new HTTPS certificate binding support; improved formatting and organization of store type creation and store creation sections; corrected spelling errors |
| docsource/content.md | Added documentation for HTTPS and VPN certificate binding limitations |
| CHANGELOG.md | Added v1.3.0 entry documenting HTTPS server certificate renewal support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| //limitations under the License. | ||
|
|
||
| using Newtonsoft.Json; | ||
| using System.Text.Json.Serialization; |
There was a problem hiding this comment.
This file uses both Newtonsoft.Json (line 14) and System.Text.Json.Serialization (line 15) namespaces, but only Newtonsoft.Json attributes are actually used in the code. The System.Text.Json.Serialization import is unnecessary and should be removed to maintain consistency with other API classes in the codebase (which use only Newtonsoft.Json).
| using System.Text.Json.Serialization; |
| using System.Text; | ||
| using System.Net.Http.Headers; | ||
| using Microsoft.Extensions.Logging; | ||
| using Org.BouncyCastle.Asn1.Ocsp; |
There was a problem hiding this comment.
The imported namespace Org.BouncyCastle.Asn1.Ocsp appears to be unused. Consider removing this import as it's not referenced anywhere in the code.
| using Org.BouncyCastle.Asn1.Ocsp; |
No description provided.