Win cert changes (#49) #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored code adding Windows cert store logic, including renaming IISU to WinIIS. * Added PowerShell class to perform get-childitem from cert store * Refactored code allowing multiple types of Cert Stores, including Win Cert and IIS (WebHosting) Cert Stores. * Update generated README * Fixed a problem adding certs to a cert store that had a space in the name (ie. Remote Desktop) --------- Co-authored-by: Bob Pokorny <bpokorny@keyfactor.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
rcpokorny
approved these changes
Mar 15, 2023
… text. (#55) Co-authored-by: Bob Pokorny <bpokorny@keyfactor.com>
… text. (#56) Co-authored-by: Bob Pokorny <bpokorny@keyfactor.com>
* Created custom Configuration Property Parser so not to display or log passwords. * Masked Private Ket Password * Modified logging to write out as JSON object --------- Co-authored-by: Bob Pokorny <bpokorny@keyfactor.com>
adding store-type definitions for `WinCert` and `IISU`
…estrator into Update_ReadME
…estrator into Update_ReadME
Update read me
fiddlermikey
added a commit
that referenced
this pull request
Apr 12, 2023
* Win cert changes (#49) (#50) * Win cert changes (#49) * Refactored code adding Windows cert store logic, including renaming IISU to WinIIS. * Added PowerShell class to perform get-childitem from cert store * Refactored code allowing multiple types of Cert Stores, including Win Cert and IIS (WebHosting) Cert Stores. * Update generated README * Fixed a problem adding certs to a cert store that had a space in the name (ie. Remote Desktop) * Updated Change Log. * Removed logging of PAM credentials which was logging the info in plain text. (#55) * Created custom Configuration Property Parser (#57) * Created custom Configuration Property Parser so not to display or log passwords. * Masked Private Ket Password * Modified logging to write out as JSON object * adding store-type definitions for `WinCert` and `IISU` * Updated ReadMe to better reflect IISU and WinCert settings. * Updated Cert Stores and images * Replaced Images * update workflow (#63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored code adding Windows cert store logic, including renaming IISU to WinIIS.
Added PowerShell class to perform get-childitem from cert store
Refactored code allowing multiple types of Cert Stores, including Win Cert and IIS (WebHosting) Cert Stores.
Update generated README
Fixed a problem adding certs to a cert store that had a space in the name (ie. Remote Desktop)