Fix dictionary error #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New description in manifiest * Readme updates * Make test cases in readme collapsible * Fix casing on Username * Cleanup readme property tables * Cleanup property tables in readme * Readme property table cleanup * Clean up cert store creation tables in readme * Update readme images, tables. Remove old images. * Add missing note on dependency parameters * Update generated README --------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
Added description for site name error when issuing a WinCert job.
rcpokorny
approved these changes
May 8, 2023
RexWheeler
added a commit
that referenced
this pull request
May 8, 2023
* Fix dictionary error (#67) * Fixed missing parameter error when writing out settings to log file. * Update generated README * Readme to fixdictionary (#66) * New description in manifiest * Readme updates * Make test cases in readme collapsible * Fix casing on Username * Cleanup readme property tables * Cleanup property tables in readme * Readme property table cleanup * Clean up cert store creation tables in readme * Update readme images, tables. Remove old images. * Add missing note on dependency parameters * Update generated README --------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> * Update CHANGELOG.md * Update CHANGELOG.md Added description for site name error when issuing a WinCert job. --------- Co-authored-by: Bob Pokorny <bpokorny@keyfactor.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> Co-authored-by: Rex Wheeler <rex@fuzzytiger.com> * Fix dictionary error (#67) * Fixed missing parameter error when writing out settings to log file. * Update generated README * Readme to fixdictionary (#66) * New description in manifiest * Readme updates * Make test cases in readme collapsible * Fix casing on Username * Cleanup readme property tables * Cleanup property tables in readme * Readme property table cleanup * Clean up cert store creation tables in readme * Update readme images, tables. Remove old images. * Add missing note on dependency parameters * Update generated README --------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> * Update CHANGELOG.md * Update CHANGELOG.md Added description for site name error when issuing a WinCert job. --------- Co-authored-by: Bob Pokorny <bpokorny@keyfactor.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> Co-authored-by: Rex Wheeler <rex@fuzzytiger.com> * Fix dictionary error (#71) * Fixed missing parameter error when writing out settings to log file. * Update generated README * Readme to fixdictionary (#66) * New description in manifiest * Readme updates * Make test cases in readme collapsible * Fix casing on Username * Cleanup readme property tables * Cleanup property tables in readme * Readme property table cleanup * Clean up cert store creation tables in readme * Update readme images, tables. Remove old images. * Add missing note on dependency parameters * Update generated README --------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> * Update CHANGELOG.md * Update CHANGELOG.md Added description for site name error when issuing a WinCert job. --------- Co-authored-by: Bob Pokorny <bpokorny@keyfactor.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> Co-authored-by: Bob Pokorny <55611381+rcpokorny@users.noreply.github.com> * Update generated README --------- Co-authored-by: Bob Pokorny <55611381+rcpokorny@users.noreply.github.com> Co-authored-by: Bob Pokorny <bpokorny@keyfactor.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Bob and Rex's changes into 2.1 for a 2.1.1 build (which we don't plan on releasing because a 2.2 is on the way soon)