From 9e3205ebea3951a1b0df071649efb4ecb582ea83 Mon Sep 17 00:00:00 2001 From: asmith236 Date: Wed, 5 Apr 2023 21:10:10 -0700 Subject: [PATCH 1/2] fix GetSecurityRoles return value --- api/security.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/security.go b/api/security.go index 39280e5..dddebb3 100644 --- a/api/security.go +++ b/api/security.go @@ -111,7 +111,7 @@ func (c *Client) DeleteSecurityIdentity(id int) error { return nil } -func (c *Client) GetSecurityRoles() ([]GetSecurityRolesResponse, error) { +func (c *Client) GetSecurityRoles() (GetSecurityRolesResponse, error) { log.Println("[INFO] Getting list of Keyfactor security roles") // Set Keyfactor-specific headers @@ -134,7 +134,7 @@ func (c *Client) GetSecurityRoles() ([]GetSecurityRolesResponse, error) { return nil, err } - var jsonResp []GetSecurityRolesResponse + var jsonResp GetSecurityRolesResponse err = json.NewDecoder(resp.Body).Decode(&jsonResp) if err != nil { return nil, err From 8d5300d2ba8d9b8f978bd93a7888216a26f89cda Mon Sep 17 00:00:00 2001 From: asmith236 Date: Wed, 5 Apr 2023 21:10:32 -0700 Subject: [PATCH 2/2] add original v1.3.3 fix --- api/certificate.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/certificate.go b/api/certificate.go index 5a02c13..3a2bdbf 100644 --- a/api/certificate.go +++ b/api/certificate.go @@ -241,7 +241,7 @@ func (c *Client) RevokeCert(rvargs *RevokeCertArgs) error { return errors.New("invalid or nonexistent values required for certificate revocation") } - if rvargs.EffectiveDate == "" { + if rvargs.EffectiveDate == "" || rvargs.EffectiveDate == "{null}" || rvargs.EffectiveDate == "null" { rvargs.EffectiveDate = getTimestamp() }