Skip to content

Create --from-file flag to configure new certificate store type from JSON file #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2023
Merged

Create --from-file flag to configure new certificate store type from JSON file #14

merged 1 commit into from
Jan 25, 2023

Conversation

@m8rmclaren
Copy link
Contributor

@m8rmclaren m8rmclaren commented Jan 25, 2023

  • Created new Cobra string flag called from-file under the store-types create command
  • If this string is not empty, the file specified in the from-file flag is read
  • Data is serialized to an api.CertificateStoreType struct and passed to the Keyfactor Go Client for creation

@m8rmclaren m8rmclaren added enhancement New feature or request go Pull requests that update Go code labels Jan 25, 2023
@m8rmclaren m8rmclaren requested a review from spbsoluble January 25, 2023 21:56
@spbsoluble spbsoluble merged commit 6b5c8e1 into main Jan 25, 2023
@spbsoluble spbsoluble deleted the create_store_type_from_file branch September 28, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spbsoluble spbsoluble spbsoluble approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m8rmclaren @spbsoluble