Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSearch package ignores default browser on Win10 #11

Closed
mtaki14 opened this issue Mar 9, 2016 · 11 comments
Closed

WebSearch package ignores default browser on Win10 #11

mtaki14 opened this issue Mar 9, 2016 · 11 comments
Labels
Milestone

Comments

@mtaki14
Copy link

@mtaki14 mtaki14 commented Mar 9, 2016

Tested with Chrome, Vivaldi, Firefox. IE is used for web searches in every case.

Windows 10

@mtaki14 mtaki14 changed the title Bug: WebSearch package ignores default browser/ Always uses Internet Explorer [Bug] WebSearch package ignores default browser/ Always uses Internet Explorer Mar 9, 2016
@polyvertex
Copy link
Member

@polyvertex polyvertex commented Mar 9, 2016

It seems that changing the default web browser on Windows 10 is trickier than on previous versions. Have your tried the procedure described here for example?

@mtaki14
Copy link
Author

@mtaki14 mtaki14 commented Mar 9, 2016

Yes. Opening links from outside a browser opens whichever browser I have set as default. I don't think it's a case of not setting the default browser properly.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Mar 9, 2016

Confirmed. Win10's machinery for that matter is slightly different.
I will provide a fix but I might have to ask you to test it as I do not have a Win10 handy.

@mtaki14
Copy link
Author

@mtaki14 mtaki14 commented Mar 9, 2016

Sure, just let me know.

@polyvertex polyvertex changed the title [Bug] WebSearch package ignores default browser/ Always uses Internet Explorer WebSearch package ignores default browser/ Always uses Internet Explorer Mar 9, 2016
@polyvertex polyvertex added the kind/bug label Mar 9, 2016
@polyvertex polyvertex changed the title WebSearch package ignores default browser/ Always uses Internet Explorer WebSearch package ignores default browser win Win10 Mar 9, 2016
@polyvertex polyvertex changed the title WebSearch package ignores default browser win Win10 WebSearch package ignores default browser on Win10 Mar 9, 2016
@polyvertex
Copy link
Member

@polyvertex polyvertex commented Mar 9, 2016

May I ask you to test this on a Windows 10?

Instructions:

  • Download this fix (edit: link removed to avoid confusion, final fix available below)
  • Exit Keypirinha
  • Extract the content of the downloaded archive to the python\site folder in Keypirinha's install directory (destination file can be overwritten)
  • Start Keypirinha and check if the problem still occurs
@mtaki14
Copy link
Author

@mtaki14 mtaki14 commented Mar 9, 2016

Nope, issue persists unfortunately.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Mar 9, 2016

Second try? (same instructions)

@mtaki14
Copy link
Author

@mtaki14 mtaki14 commented Mar 9, 2016

Now it works! Findings:
-Vivaldi/Chrome: Searches open in a new window (instead of a new tab) when a browser instance is already running
-Firefox: Works as expected, opens new tab.

@polyvertex polyvertex added this to the v2.2 milestone Mar 9, 2016
@polyvertex
Copy link
Member

@polyvertex polyvertex commented Mar 9, 2016

Ok.

About your observations, the "new tab" behavior is unfortunately up to the browser. The only thing you can do is tweaking the new_window setting (WebSearch package). Edit: but it is, at best, a hint given to the browser.

@mtaki14
Copy link
Author

@mtaki14 mtaki14 commented Mar 9, 2016

Bingo! Changing that setting to "no" opens searches in tabs. Cheers.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Mar 10, 2016

Fixed in v2.2.

@polyvertex polyvertex closed this Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.