Websearch is no more working with 2.9.8 and firefox (waterfox 49.0.2)

[robinhoodhimself]

12:18:09.584 WARNING: WebSearch.WebSearch: Could not execute item "WebSearch Google". Site "google" not found.
12:18:36.659 WARNING: WebSearch.WebSearch: Could not execute item "WebSearch Google". Site "google" not found.
12:18:58.893 WARNING: WebSearch.WebSearch: Could not execute item "WebSearch Google". Site "google" not found.
12:21:25.302 WARNING: WebSearch.WebSearch: Could not execute item "WebSearch ystocks". Site "ystocks" not found.
12:33:17.450 WARNING: WebSearch.WebSearch: Could not execute item "WebSearch ystocks". Site "ystocks" not found.
12:45:29.296 WARNING: WebSearch.WebSearch: Could not execute item "WebSearch ystocks". Site "ystocks" not found.
12:51:50.702 WARNING: WebSearch.WebSearch: Could not execute item "WebSearch Wikipedia". Site "wikipedia" not found.
13:33:13.464 WARNING: WebSearch.WebSearch: Could not execute item "WebSearch Google". Site "google" not found.
13:33:41.447 WARNING: WebSearch.WebSearch: Could not execute item "WebSearch DuckDuckGo". Site "duckduckgo" not found.
14:00:59.086 WARNING: WebSearch.WebSearch: Could not execute item "WebSearch DuckDuckGo". Site "duckduckgo" not found.

I had to go back to 2.9.7.

[polyvertex]

WebSearch's source code hasn't changed since v2.9. I suspect you have a configuration problem or maybe made an unwanted operation on files while upgrading? What's your WebSearch config?

[robinhoodhimself]

1. I just went back to 2.9.7 and websearch was fine without modifying the keypirinha profile. (I'm using the profile storage)
2. A. First I replaced the package from 2.9.8 with the one from 2.9.7 and I had error message in the console
3. B. "WebSearch's source code hasn't changed since v2.9." Maybe, but it has been recompiled because modified date is different.
4. I'm on W7 64bits. My config is stored in the profile.
5. I've attached my websearch.ini stored in the profile.

websearch.zip

[polyvertex]

I could not reproduce your issue and still can't given the provided information. The warning messages you get indicate these search sites are not found in the currently loaded config. Is your websearch.ini located into portable\Profile\User or %APPDATA%\Keypirinha\User? Saying "the profile storage" is a bit vague as both locations are profile storage.

Also be aware that the predefined_site sections you added should be prefixed by site instead of predefined_site. This is best practice. Only difference is predefined_site sections are controlled by the enable_predefined_sites settings, whereas site sections are not.

... Maybe, but it has been recompiled because modified date is different.

It seems you're getting into deep water here, there is nothing to be "compiled". Keypirinha directly reads and interpret plugins source code at runtime. Again, fact is WebSearch source code hasn't changed between 2.9.7 (which is your version of reference) and 2.9.8. That is the reason why your issue seems to be an install/update/config problem at first glance.

[robinhoodhimself]

I 'm not using the portable folder. My config is stored in my user's roaming profile.

[polyvertex]

Have you removed the portable folder from Keypirinha's install dir?

[robinhoodhimself]

Yes. That what's I implied when saying "I'm not using the portable folder." I'm using keypirinha since 2.9.5 in "Installed mode". Did the previous update without any problem.
Did you test 2.9.8 with the roaming profile?

[polyvertex]

Yes, 2.9.8 "works for me" in installed and in portable mode, using config files from a 2.9.7 migration. Your websearch.ini is interpreted successfully and I have been able to execute WebSearch's items flawlessly during the test, being they new or from the history. Items from the Apps and other plugins do work properly as well.

[robinhoodhimself]

Console message when starting 2.9.8 with config stored in roaming profile.

18:59:32.384 Keypirinha 2.9.8 (534dc2c) for x64
18:59:32.384 Installed mode.
18:59:32.385 System: WinNT-x64 6.1.7601-ws-0x0100 SP1.0
18:59:32.386 Official packages: C:\Program Files\Keypirinha\default\Packages
18:59:32.386 Profile dir: C:\Users\robin\AppData\Roaming\Keypirinha
18:59:32.386 Local dir: C:\Users\robin\AppData\Local\Keypirinha
18:59:32.386 Keyboard layout: 0000080C
18:59:32.387 Monitor #1: Name[\.\DISPLAY1] Rect[0, 0, 1920, 1200] DpiScale[1.00] PRIMARY
18:59:32.426 Python 3.5.2 (default, Jul 1 2016, 10:33:08) [MSC v.1800 64 bit (AMD64)]
18:59:32.703 WARNING: Failed to get path of KnownFolder ACCOUNTPICTURES (code -0X7FF8FFFE).
18:59:32.703 WARNING: Failed to get path of KnownFolder CAMERAROLL (code -0X7FF8FFFE).
18:59:32.709 WARNING: Failed to get path of KnownFolder SCREENSHOTS (code -0X7FF8FFFE).
18:59:32.709 WARNING: Failed to get path of KnownFolder SKYDRIVE (code -0X7FF8FFFE).
18:59:32.709 WARNING: Failed to get path of KnownFolder SKYDRIVECAMERAROLL (code -0X7FF8FFFE).
18:59:32.709 WARNING: Failed to get path of KnownFolder SKYDRIVEDOCUMENTS (code -0X7FF8FFFE).
18:59:32.709 WARNING: Failed to get path of KnownFolder SKYDRIVEPICTURES (code -0X7FF8FFFE).
18:59:32.724 WARNING: Failed to get path of KnownFolder ACCOUNTPICTURES (code -0X7FF8FFFE).
18:59:32.724 WARNING: Failed to get path of KnownFolder CAMERAROLL (code -0X7FF8FFFE).
18:59:32.724 WARNING: Failed to get path of KnownFolder SCREENSHOTS (code -0X7FF8FFFE).
18:59:32.724 WARNING: Failed to get path of KnownFolder SKYDRIVE (code -0X7FF8FFFE).
18:59:32.724 WARNING: Failed to get path of KnownFolder SKYDRIVECAMERAROLL (code -0X7FF8FFFE).
18:59:32.724 WARNING: Failed to get path of KnownFolder SKYDRIVEDOCUMENTS (code -0X7FF8FFFE).
18:59:32.725 WARNING: Failed to get path of KnownFolder SKYDRIVEPICTURES (code -0X7FF8FFFE).
18:59:32.822 Loaded 654 items from history file.
18:59:32.855 Init done in 0.4900s, including 0.3044s (62%) for the Python interpreter.
18:59:32.856 Plugin loaded: Internal.About
18:59:32.913 Plugin loaded: Apps.Apps (instance #1)
18:59:32.932 Plugin loaded: Bookmarks.Bookmarks (instance #1)
18:59:32.942 Plugin loaded: Calc.Calc (instance #1)
18:59:32.945 Plugin loaded: ControlPanel.ControlPanel (instance #1)
18:59:32.952 Plugin loaded: Everything.Everything (instance #1)
18:59:32.956 Plugin loaded: FileBrowser.FileBrowser (instance #1)
18:59:32.968 Plugin loaded: FileZilla.FileZilla (instance #1)
18:59:32.972 Plugin loaded: PuTTY.PuTTY (instance #1)
18:59:32.978 Plugin loaded: RegBrowser.RegBrowser (instance #1)
18:59:32.982 Plugin loaded: TaskSwitcher.TaskSwitcher (instance #1)
18:59:32.985 Plugin loaded: URL.URL (instance #1)
18:59:32.989 Plugin loaded: WebSearch.WebSearch (instance #1)
18:59:32.993 Plugin loaded: Winamp.Winamp (instance #1)
18:59:32.997 Plugin loaded: WinSCP.WinSCP (instance #1)
18:59:33.056 ** ERROR: Error from WebSearch.WebSearch.on_start: <class 'IndexError'>: list index out of range
Traceback (most recent call last):
File "C:\Program Files\Keypirinha\default\Packages\WebSearch.keypirinha-package\websearch.py", line 36, in on_start
File "C:\Program Files\Keypirinha\default\Packages\WebSearch.keypirinha-package\websearch.py", line 97, in _setup_default_icon
File "C:\Program Files\Keypirinha\python\site\keypirinha_util.py", line 963, in web_browser_command
return cmdlines[0]
18:59:33.058 ** ERROR: Error from WebSearch.WebSearch.on_catalog: <class 'IndexError'>: list index out of range
Traceback (most recent call last):
File "C:\Program Files\Keypirinha\default\Packages\WebSearch.keypirinha-package\websearch.py", line 39, in on_catalog
File "C:\Program Files\Keypirinha\default\Packages\WebSearch.keypirinha-package\websearch.py", line 97, in _setup_default_icon
File "C:\Program Files\Keypirinha\python\site\keypirinha_util.py", line 963, in web_browser_command
return cmdlines[0]
18:59:33.337 Apps.Apps: Cataloged 1119 items in 0.3 seconds
18:59:33.717 Bookmarks.Bookmarks: Referenced 3048 bookmarks

Console message when starting 2.9.7 with exactly same config stored in roaming profile.

19:08:08.021 Keypirinha 2.9.7 (c3f6538) for x64
19:08:08.022 Installed mode.
19:08:08.022 System: WinNT-x64 6.1.7601-ws-0x0100 SP1.0
19:08:08.023 Official packages: C:\Program Files\Keypirinha\default\Packages
19:08:08.023 Profile dir: C:\Users\robin\AppData\Roaming\Keypirinha
19:08:08.023 Local dir: C:\Users\robin\AppData\Local\Keypirinha
19:08:08.023 Keyboard layout: 0000080C
19:08:08.024 Monitor #1: Name[\.\DISPLAY1] Rect[0, 0, 1920, 1200] DpiScale[1.00] PRIMARY
19:08:08.064 Python 3.5.2 (default, Jul 1 2016, 10:33:08) [MSC v.1800 64 bit (AMD64)]
19:08:08.329 WARNING: Failed to get path of KnownFolder ACCOUNTPICTURES (code -0X7FF8FFFE).
19:08:08.329 WARNING: Failed to get path of KnownFolder CAMERAROLL (code -0X7FF8FFFE).
19:08:08.334 WARNING: Failed to get path of KnownFolder SCREENSHOTS (code -0X7FF8FFFE).
19:08:08.334 WARNING: Failed to get path of KnownFolder SKYDRIVE (code -0X7FF8FFFE).
19:08:08.334 WARNING: Failed to get path of KnownFolder SKYDRIVECAMERAROLL (code -0X7FF8FFFE).
19:08:08.334 WARNING: Failed to get path of KnownFolder SKYDRIVEDOCUMENTS (code -0X7FF8FFFE).
19:08:08.334 WARNING: Failed to get path of KnownFolder SKYDRIVEPICTURES (code -0X7FF8FFFE).
19:08:08.350 WARNING: Failed to get path of KnownFolder ACCOUNTPICTURES (code -0X7FF8FFFE).
19:08:08.350 WARNING: Failed to get path of KnownFolder CAMERAROLL (code -0X7FF8FFFE).
19:08:08.350 WARNING: Failed to get path of KnownFolder SCREENSHOTS (code -0X7FF8FFFE).
19:08:08.350 WARNING: Failed to get path of KnownFolder SKYDRIVE (code -0X7FF8FFFE).
19:08:08.350 WARNING: Failed to get path of KnownFolder SKYDRIVECAMERAROLL (code -0X7FF8FFFE).
19:08:08.350 WARNING: Failed to get path of KnownFolder SKYDRIVEDOCUMENTS (code -0X7FF8FFFE).
19:08:08.350 WARNING: Failed to get path of KnownFolder SKYDRIVEPICTURES (code -0X7FF8FFFE).
19:08:08.446 Loaded 654 items from history file.
19:08:08.481 Init done in 0.4790s, including 0.2924s (61%) for the Python interpreter.
19:08:08.482 Plugin loaded: Internal.About
19:08:08.536 Plugin loaded: Apps.Apps (instance #1)
19:08:08.553 Plugin loaded: Bookmarks.Bookmarks (instance #1)
19:08:08.562 Plugin loaded: Calc.Calc (instance #1)
19:08:08.565 Plugin loaded: ControlPanel.ControlPanel (instance #1)
19:08:08.572 Plugin loaded: Everything.Everything (instance #1)
19:08:08.575 Plugin loaded: FileBrowser.FileBrowser (instance #1)
19:08:08.586 Plugin loaded: FileZilla.FileZilla (instance #1)
19:08:08.590 Plugin loaded: PuTTY.PuTTY (instance #1)
19:08:08.595 Plugin loaded: RegBrowser.RegBrowser (instance #1)
19:08:08.599 Plugin loaded: TaskSwitcher.TaskSwitcher (instance #1)
19:08:08.602 Plugin loaded: URL.URL (instance #1)
19:08:08.606 Plugin loaded: WebSearch.WebSearch (instance #1)
19:08:08.610 Plugin loaded: Winamp.Winamp (instance #1)
19:08:08.613 Plugin loaded: WinSCP.WinSCP (instance #1)
19:08:08.761 WARNING: WebSearch.WebSearch: Ignoring duplicated site "Bing" defined in section "site/Bing".
19:08:08.762 WARNING: WebSearch.WebSearch: Ignoring duplicated site "Google" defined in section "site/Google".
19:08:08.762 WARNING: WebSearch.WebSearch: Ignoring duplicated site "IMDB" defined in section "site/IMDB".
19:08:08.762 WARNING: WebSearch.WebSearch: Ignoring duplicated site "Wikipedia" defined in section "site/Wikipedia".
19:08:08.952 Apps.Apps: Cataloged 1119 items in 0.3 seconds
19:08:09.224 Bookmarks.Bookmarks: Referenced 3048 bookmarks

In your test did you use Win 7 64bits?

[robinhoodhimself]

File keypirinha_util.py dated 20/11/2016 is the problem on my system.
Replacing it with the old dated 02/10/2016 seems to solve the problem.

19:26:48.532 Keypirinha 2.9.8 (534dc2c) for x64
19:26:48.532 Installed mode.
19:26:48.532 System: WinNT-x64 6.1.7601-ws-0x0100 SP1.0
19:26:48.533 Official packages: C:\Program Files\Keypirinha\default\Packages
19:26:48.533 Profile dir: C:\Users\robin\AppData\Roaming\Keypirinha
19:26:48.533 Local dir: C:\Users\robin\AppData\Local\Keypirinha
19:26:48.533 Keyboard layout: 0000080C
19:26:48.534 Monitor #1: Name[\.\DISPLAY1] Rect[0, 0, 1920, 1200] DpiScale[1.00] PRIMARY
19:26:48.572 Python 3.5.2 (default, Jul 1 2016, 10:33:08) [MSC v.1800 64 bit (AMD64)]
19:26:48.843 WARNING: Failed to get path of KnownFolder ACCOUNTPICTURES (code -0X7FF8FFFE).
19:26:48.843 WARNING: Failed to get path of KnownFolder CAMERAROLL (code -0X7FF8FFFE).
19:26:48.848 WARNING: Failed to get path of KnownFolder SCREENSHOTS (code -0X7FF8FFFE).
19:26:48.848 WARNING: Failed to get path of KnownFolder SKYDRIVE (code -0X7FF8FFFE).
19:26:48.848 WARNING: Failed to get path of KnownFolder SKYDRIVECAMERAROLL (code -0X7FF8FFFE).
19:26:48.848 WARNING: Failed to get path of KnownFolder SKYDRIVEDOCUMENTS (code -0X7FF8FFFE).
19:26:48.848 WARNING: Failed to get path of KnownFolder SKYDRIVEPICTURES (code -0X7FF8FFFE).
19:26:48.863 WARNING: Failed to get path of KnownFolder ACCOUNTPICTURES (code -0X7FF8FFFE).
19:26:48.863 WARNING: Failed to get path of KnownFolder CAMERAROLL (code -0X7FF8FFFE).
19:26:48.864 WARNING: Failed to get path of KnownFolder SCREENSHOTS (code -0X7FF8FFFE).
19:26:48.864 WARNING: Failed to get path of KnownFolder SKYDRIVE (code -0X7FF8FFFE).
19:26:48.864 WARNING: Failed to get path of KnownFolder SKYDRIVECAMERAROLL (code -0X7FF8FFFE).
19:26:48.864 WARNING: Failed to get path of KnownFolder SKYDRIVEDOCUMENTS (code -0X7FF8FFFE).
19:26:48.864 WARNING: Failed to get path of KnownFolder SKYDRIVEPICTURES (code -0X7FF8FFFE).
19:26:48.958 Loaded 654 items from history file.
19:26:48.998 Init done in 0.4850s, including 0.2979s (61%) for the Python interpreter.
19:26:48.999 Plugin loaded: Internal.About
19:26:49.052 Plugin loaded: Apps.Apps (instance #1)
19:26:49.069 Plugin loaded: Bookmarks.Bookmarks (instance #1)
19:26:49.079 Plugin loaded: Calc.Calc (instance #1)
19:26:49.081 Plugin loaded: ControlPanel.ControlPanel (instance #1)
19:26:49.088 Plugin loaded: Everything.Everything (instance #1)
19:26:49.092 Plugin loaded: FileBrowser.FileBrowser (instance #1)
19:26:49.103 Plugin loaded: FileZilla.FileZilla (instance #1)
19:26:49.107 Plugin loaded: PuTTY.PuTTY (instance #1)
19:26:49.112 Plugin loaded: RegBrowser.RegBrowser (instance #1)
19:26:49.116 Plugin loaded: TaskSwitcher.TaskSwitcher (instance #1)
19:26:49.120 Plugin loaded: URL.URL (instance #1)
19:26:49.123 Plugin loaded: WebSearch.WebSearch (instance #1)
19:26:49.127 Plugin loaded: Winamp.Winamp (instance #1)
19:26:49.131 Plugin loaded: WinSCP.WinSCP (instance #1)
19:26:49.218 WARNING: WebSearch.WebSearch: Ignoring duplicated site "Bing" defined in section "site/Bing".
19:26:49.218 WARNING: WebSearch.WebSearch: Ignoring duplicated site "Google" defined in section "site/Google".
19:26:49.218 WARNING: WebSearch.WebSearch: Ignoring duplicated site "IMDB" defined in section "site/IMDB".
19:26:49.218 WARNING: WebSearch.WebSearch: Ignoring duplicated site "Wikipedia" defined in section "site/Wikipedia".
19:26:49.461 Apps.Apps: Cataloged 1119 items in 0.3 seconds
19:26:49.723 Bookmarks.Bookmarks: Referenced 3048 bookmarks

[polyvertex]

Well, with so much obvious trouble noticeable on those logs, I don't quite get why you didn't start by sending them as-is! That would have saved me some time and prevented you from giving biased info... 3 remarks:

• The "KnownFolder" warnings are to be expected on your system since these ones didn't exist before Win8 or Win8.1 for some of them, so unless you're trying to use them in your config file, you can safely ignore them (you would have an error message box anyway).
• The "Ignoring duplicated" messages don't match with the config file you previously attached here
• The keypirinha_util.web_browser_command received an overhaul since 2.9.7 and is probably the root of your issue. I'll investigate further.

[polyvertex]

Here is a hotfix version of keypirinha_util.py that should work. Please keep using 2.9.8 to ensure the rest works properly.

[robinhoodhimself]

• Well, with so much obvious trouble noticeable on those logs, I don't quite get why you didn't start by sending them as-is! That would have saved me some time and prevented you from giving biased info... 3 remarks:

Vu que j'utilise beaucoup l'application et que j'ai eut l'impression que tu n'allais peut-être pas y arriver j'ai décidé d'y investir un peu plus de mon cerveau. ;-)

• "The "Ignoring duplicated" messages don't match with the config file you previously attached here"

That's normal I've moved those sites to the [Site/] part of the ini.
They seems to be coded somewhere else so now I removed them from the [Site/] part.
In the websearch.ini I've sent you they are still in the [Predifined_Site/].
You should remove [Predifined_Site/] and merge all the site in [Site/***].

The hotfix is working fine.

[polyvertex]

That's normal I've moved those sites to the [Site/***] part of the ini

That is not how it works. If a search site is already in the original config file, say [predefined_site/Google] for example, but you want to alter its configuration as it is defined by default, you must keep its original section name (i.e. [predefined_site/Google]).

If you want to declare a new site that is not already predefined, you should use the [site/MyNewSearchSite] naming format for its section.

Release 2.9.9 has just been released BTW and includes the corrected version of keypirinha_util.py. Therefore I'm closing this issue, feel free to comment further if needed.