Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Prompt environment variable prevents startup #14

Closed
ghost opened this Issue Mar 11, 2016 · 7 comments

Comments

Projects
None yet
1 participant
@ghost
Copy link

ghost commented Mar 11, 2016

Using PROMPT=$P$_$G causes the following startup error:

Exception caught: Failed to construct PythonIni object Python exception: <class 'ValueError'>: invalid interpolation syntax in '$P$_$G' at position 0
Traceback (most recent call last):
File "lib\configparser.py", line 751, in read_dict
File "lib\configparser.py", line 891, in set
File "lib\configparser.py", line 462, in before_set

@polyvertex

This comment has been minimized.

Copy link
Member

polyvertex commented Mar 11, 2016

Can you confirm that KP behaves as expected if you temporary delete the PROMPT env var, or if you just modify it to something less exotic?

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Mar 11, 2016

Yes, changing to PROMPT=$P$G launches successfully

@polyvertex polyvertex added the kind/bug label Mar 11, 2016

@polyvertex polyvertex added this to the v2.3 milestone Mar 11, 2016

@polyvertex

This comment has been minimized.

Copy link
Member

polyvertex commented Mar 11, 2016

Bug confirmed. Thank you for filing the bug.

Are you Launchy's Simon Capewell BTW? Your name was ringing a bell so I double checked in Launchy's files. :)

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Mar 11, 2016

Yes, that’s me!

@polyvertex

This comment has been minimized.

Copy link
Member

polyvertex commented Mar 12, 2016

Fix is done and will be part of the next release. Nice catch!

That said, it is weird that your second test worked (i.e. the one with the $P$G value). I mean, it shouldn't work (and actually it didn't for me). As things are in v2.2 and previous, any environment value having a single dollar sign somewhere in it would fail. Are you positive about the result of your second test?

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Mar 16, 2016

Actually, you're right; clearing prompt back to default avoids the bug. If you explicitly set $P$G, startup still fails.

@polyvertex

This comment has been minimized.

Copy link
Member

polyvertex commented Mar 22, 2016

Fixed in 2.3

@polyvertex polyvertex closed this Mar 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.