Use biggest available icon #143

Closed
szepeviktor opened this Issue Dec 26, 2016 · 8 comments

Comments

Projects
None yet
2 participants
@szepeviktor

szepeviktor commented Dec 26, 2016

Click on the image to see the difference in quality

kp-big-icon

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Dec 26, 2016

Member

KP already tries to load the best available quality and you've found a special case.
Icon loading on Windows is not a trivial thing as the file format is inherited from the 16bit days and it is such a compatibility mess that some icon creator applications just do it wrong.
This require investigation.

Member

polyvertex commented Dec 26, 2016

KP already tries to load the best available quality and you've found a special case.
Icon loading on Windows is not a trivial thing as the file format is inherited from the 16bit days and it is such a compatibility mess that some icon creator applications just do it wrong.
This require investigation.

@szepeviktor

This comment has been minimized.

Show comment
Hide comment
@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Jan 11, 2017

Member

It appears the icon format is perfectly standard in your example. Only Keypirinha's algorithm to choose the best available icon was incorrect in this case. It's fixed and will be available in next release. Thanks for your feedback.

Member

polyvertex commented Jan 11, 2017

It appears the icon format is perfectly standard in your example. Only Keypirinha's algorithm to choose the best available icon was incorrect in this case. It's fixed and will be available in next release. Thanks for your feedback.

@szepeviktor

This comment has been minimized.

Show comment
Hide comment

Thank you.

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Jan 11, 2017

Member

Reopening this until release.

Member

polyvertex commented Jan 11, 2017

Reopening this until release.

@polyvertex polyvertex reopened this Jan 11, 2017

@szepeviktor

This comment has been minimized.

Show comment
Hide comment

szepeviktor commented Jan 11, 2017

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Jan 11, 2017

Member

Users don't know what milestones are, alas. Leaving the issue open and on first page prevents some to open a new one.

Member

polyvertex commented Jan 11, 2017

Users don't know what milestones are, alas. Leaving the issue open and on first page prevents some to open a new one.

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Jan 14, 2017

Member

Fixed in v2.9.10

Member

polyvertex commented Jan 14, 2017

Fixed in v2.9.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment