Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use biggest available icon #143

Closed
szepeviktor opened this issue Dec 26, 2016 · 8 comments
Closed

Use biggest available icon #143

szepeviktor opened this issue Dec 26, 2016 · 8 comments

Comments

@szepeviktor
Copy link

szepeviktor commented Dec 26, 2016

Click on the image to see the difference in quality

kp-big-icon

@polyvertex
Copy link
Member

KP already tries to load the best available quality and you've found a special case.
Icon loading on Windows is not a trivial thing as the file format is inherited from the 16bit days and it is such a compatibility mess that some icon creator applications just do it wrong.
This require investigation.

@szepeviktor
Copy link
Author

@polyvertex
Copy link
Member

It appears the icon format is perfectly standard in your example. Only Keypirinha's algorithm to choose the best available icon was incorrect in this case. It's fixed and will be available in next release. Thanks for your feedback.

@szepeviktor
Copy link
Author

Thank you.

@polyvertex
Copy link
Member

Reopening this until release.

@polyvertex polyvertex reopened this Jan 11, 2017
@szepeviktor
Copy link
Author

szepeviktor commented Jan 11, 2017

Milestones are for this!
https://github.com/Keypirinha/Keypirinha/milestones

@polyvertex
Copy link
Member

Users don't know what milestones are, alas. Leaving the issue open and on first page prevents some to open a new one.

@polyvertex
Copy link
Member

Fixed in v2.9.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants