Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random installers programs launching when searching #164

Closed
AshkoreDracson opened this issue Mar 15, 2017 · 7 comments
Closed

Random installers programs launching when searching #164

AshkoreDracson opened this issue Mar 15, 2017 · 7 comments

Comments

@AshkoreDracson
Copy link

@AshkoreDracson AshkoreDracson commented Mar 15, 2017

Hello!

I have installed KeyPirinha today and I love it! But I have notice a quite strange bug that seems to happens whenever you search for something for the first time.
For example, KeyPirinha will launch, I will then search for something, and in the middle of typing my query, some installer program will launch to proceed to uninstall some program.

Here is an example of the issue by typing "q" that launches QuickTime uninstaller anywhere from 1 to 5 times in a row!
Example video

I also get the same problem when starting to type "py", and it launches each python uninstaller once, one after the other.

Whenever those uninstallers have been launch at least once, reproduction of this bug is extremely inconsistent, and I have to relaunch KeyPirinha in order for it to happen again, but it's pretty annoying nonetheless.

I am running on Windows 10 Home x64, and it does this problem both on the Portable and Installed version.

Also there is no console output when this bug happens. I also don't have any third-party packages installed, it's a fresh install.

@LordYui
Copy link

@LordYui LordYui commented Mar 15, 2017

Can confirm this. We were trying the soft together, and we ran into exactly the same issue.
Here's my recording of it happening (it cuts off at the end, because UAC decided to shut off my screen recorder)

For some reasons, trying to type "Command" ended up in trying to uninstall {smartassembly}
Same thing, I was able to get it to reproduce two or three times, and now it just seems to work, I'll need to use it more to see if it comes back.

Definitely happened in both portable & installed mode. My friend was running a fresh install, and I was using the SystemCommands plugin.

I run Win10 Family on a laptop, I did not think of checking the console while the bug was still happening (sorry 'bout that).

@ueffel
Copy link

@ueffel ueffel commented Mar 15, 2017

Seems to be the similar problem as #108
I also had a colleague, who had this problem but he couldn't reproduce it consistently

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Mar 16, 2017

TL;DR: Hi, thanks for taking the time to report this in such a detailed way. I will install QuickTime and see if I manage to reproduce the issue consistently enough to be able to find a workaround. Sorry for the inconvenience.


KP's code does not explicitly launches anything unless the end-user wants to, so obviously this is done indirectly. Your screen captures suggest a tiny clue that it might be related to the icons extraction method. This really is just a wild guess.

To extract the icon from an executable, KP calls first the LoadLibraryEx function, which is part of Windows API. However in theory, no code execution should occur especially because those flags are used: LOAD_LIBRARY_AS_IMAGE_RESOURCE | LOAD_LIBRARY_AS_DATAFILE.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Mar 16, 2017

Update: I'm on Win8.1, I installed both QuickTime and smartassembly but cannot manage to reproduce the issue at all. Perhaps it's Win10-specific?

So if anyone manages to reproduce this consistently, please jump in.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Mar 16, 2017

Update 2: it sounds like only MSI installers are involved in this issue, do you confirm?

If yes, my best bet is that it is related to the introspection of some *.lnk shortcut files created by the MSI installer (still in the icon extraction method). And in that case, I can attempt to fix this blindly for the soon-to-be-released version.

@AshkoreDracson
Copy link
Author

@AshkoreDracson AshkoreDracson commented Mar 16, 2017

Yep it seems to be MSI installers only, so far I got a few versions of Python uninstallers that show up, and the quicktime uninstaller.
So my guess is indeed whenever those show up, when trying to get the icon or something it does run it for some reason.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Mar 17, 2017

Fix "attempt" applied in v2.12 :)
Please check it out.
I'm closing this but do not hesitate to report any trouble related to this issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.