New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for files in network drives not shown #20

Closed
egabrum opened this Issue Mar 22, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@egabrum

egabrum commented Mar 22, 2016

v2.3: If I place the same file in two locations, part of the catalogue:

  • One in a local drive
  • One in a network drive

The icon for the file in the local drive is shown, but not the one for the network drive (default 'blank sheet' icon shown instead)

@polyvertex

This comment has been minimized.

Member

polyvertex commented Mar 22, 2016

Is the big icon of the distant file blank as well? It's the icon on the top-left side when the item is selected.

@egabrum

This comment has been minimized.

egabrum commented Mar 22, 2016

  • For the local file (in this case, it's a .bat): both icons are the same: the standard icon for batch files.
  • For the remote file:

-> Large icon (top left): 'My PC' type of icon.
-> Icon in the suggestion list: 'blank sheet' icon.

@polyvertex

This comment has been minimized.

Member

polyvertex commented Apr 20, 2016

It appears I completely forgot about that. Funny thing is I just had to comment 3 lines of code to make it behave as expected as it was just an obsolete precaution dating from the very early days of the project.
Anyway, it will be fixed in the next release.

@polyvertex polyvertex added this to the v2.6 milestone Apr 20, 2016

@polyvertex polyvertex added the kind/bug label Apr 22, 2016

@polyvertex polyvertex closed this Apr 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment