New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable Mode - Move .history From Roaming To Local #206

Closed
laurin1 opened this Issue Jun 20, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@laurin1

laurin1 commented Jun 20, 2017

This file is can contain information that is not "portable", example and only portable files should be in Roaming

I copied by /AppData/Roaming/Keypirinha folder from one machine to another (actually syncing this folder) and I got an error that a drive was not available.

EDIT by @polyvertex: Original message on Gitter

@Andreasvb

This comment has been minimized.

Show comment
Hide comment
@Andreasvb

Andreasvb Jul 15, 2017

Portable doesn't put anything in %AppData%.
Use the portable version instead, I don't like when it's scattered around in AppData. :)
I have mine in D:\Portable\Apps\Keypirinha\

Andreasvb commented Jul 15, 2017

Portable doesn't put anything in %AppData%.
Use the portable version instead, I don't like when it's scattered around in AppData. :)
I have mine in D:\Portable\Apps\Keypirinha\

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Jul 15, 2017

Member

@Andreasvb thanks for jumping in. Actually this issue would persist if KP would be used in Portable mode. @laurin1's "hiccups" here is that the Keypirinha.history file contain information that may make KP behaving incorrectly across several computers when KP is in Installed mode due to the Keypirinha.history file being stored under C:\Users\Bob\AppData\Roaming instead of C:\Users\Bob\AppData\Local.

By convention, the C:\Users\Bob\AppData\Roaming folder is supposed to contain configuration/data files that theorically should be usable on "any" computer (see this SO answer for more info).

Not a big issue but still must be addressed.

Member

polyvertex commented Jul 15, 2017

@Andreasvb thanks for jumping in. Actually this issue would persist if KP would be used in Portable mode. @laurin1's "hiccups" here is that the Keypirinha.history file contain information that may make KP behaving incorrectly across several computers when KP is in Installed mode due to the Keypirinha.history file being stored under C:\Users\Bob\AppData\Roaming instead of C:\Users\Bob\AppData\Local.

By convention, the C:\Users\Bob\AppData\Roaming folder is supposed to contain configuration/data files that theorically should be usable on "any" computer (see this SO answer for more info).

Not a big issue but still must be addressed.

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Jul 19, 2017

Member

Should be fixed in 2.15.2.
Do not hesitate to comment if issue persists.

Member

polyvertex commented Jul 19, 2017

Should be fixed in 2.15.2.
Do not hesitate to comment if issue persists.

@polyvertex polyvertex closed this Jul 19, 2017

@laurin1

This comment has been minimized.

Show comment
Hide comment
@laurin1

laurin1 Jul 19, 2017

Sorry, but this does not appear to be fixed. On a VM to test, I removed Keypirinha folders from Local and Roaming, uninstalled 2.15.1, and installed 2.15.3, and Keypirinha.history was created in /AppData/Roaming/Keypirinha/User.

laurin1 commented Jul 19, 2017

Sorry, but this does not appear to be fixed. On a VM to test, I removed Keypirinha folders from Local and Roaming, uninstalled 2.15.1, and installed 2.15.3, and Keypirinha.history was created in /AppData/Roaming/Keypirinha/User.

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Jul 19, 2017

Member

The .history file is meant to contain user-specific information (i.e. how you use KP to improve search accuracy). Incidentally, it also has to embed machine-specific info as well. Due to the way it is designed, there is no short-term way to separate both types of data because there are tightly associated.

For that reason, the fix was not about moving the .history file to the Local folder but about ensuring that KP does not spit those error messages due to missing files.

Member

polyvertex commented Jul 19, 2017

The .history file is meant to contain user-specific information (i.e. how you use KP to improve search accuracy). Incidentally, it also has to embed machine-specific info as well. Due to the way it is designed, there is no short-term way to separate both types of data because there are tightly associated.

For that reason, the fix was not about moving the .history file to the Local folder but about ensuring that KP does not spit those error messages due to missing files.

@laurin1

This comment has been minimized.

Show comment
Hide comment
@laurin1

laurin1 commented Jul 19, 2017

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment